Give an OK of false if the PR comment exists

Author: Jon Yurek

lib/cc/services/github_pull_requests.rb

@@ -85,19 +85,17 @@ def update_status_pending
   end
 
   def update_status(state, description)
-    if config.update_status
-      params = {
-        state:       state,
-        description: description,
-        target_url:  @payload["details_url"],
-        context:     "codeclimate"
-      }
-      service_post(status_url, params.to_json)
-    end
+    params = {
+      state:       state,
+      description: description,
+      target_url:  @payload["details_url"],
+      context:     "codeclimate"
+    }
+    service_post(status_url, params.to_json)
   end
 
   def add_comment
-    if config.add_comment && !comment_present?
+    if !comment_present?
       body = {
         body: COMMENT_BODY % @payload["compare_url"]
       }.to_json
@@ -106,6 +104,8 @@ def add_comment
         doc = JSON.parse(response.body)
         { id: doc["id"] }
       end
+    else
+      { ok: false, message: "Comment already present" }
     end
   end
 

test/github_pull_requests_test.rb

@@ -38,7 +38,6 @@ def test_pull_request_status_error
       commit_sha:  "abc123",
       state:       "error",
     })
-
   end
 
   def test_pull_request_status_test_success
@@ -115,11 +114,13 @@ def test_pull_request_comment_already_present
 
     # With no POST expectation, test will fail if request is made.
 
-    receive_pull_request({ add_comment: true }, {
+    rsp = receive_pull_request({ add_comment: true, update_status: false }, {
       github_slug: "pbrisbin/foo",
       number:      1,
       state:       "success",
     })
+    assert_not_nil rsp
+    assert_false rsp[:ok]
   end
 
 private