Update all receive_test handlers to return result object

- Move result object creation out of error handling
- Return "ok" status and a test-specific message

Author: pbrisbin

lib/cc/service/invocation/with_error_handling.rb

@@ -10,13 +10,6 @@ def call
       @invocation.call
     rescue => ex
       @logger.error(error_message(ex))
-
-      {
-        error: {
-          class: ex.class,
-          message: ex.message
-        }
-      }
     end
 
     private

lib/cc/services/asana.rb

@@ -19,7 +19,14 @@ class Config < CC::Service::Config
   self.issue_tracker = true
 
   def receive_test
-    create_task("Test task from Code Climate")
+    result = create_task("Test task from Code Climate")
+
+    {
+      ok: true,
+      message: "Ticked <a href='#{result[:url]}'>#{result[:id]}</a> created."
+    }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_quality

lib/cc/services/campfire.rb

@@ -16,6 +16,10 @@ class Config < CC::Service::Config
 
   def receive_test
     speak(formatter.format_test)
+
+    { ok: true, message: "Test message sent" }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_coverage

lib/cc/services/flowdock.rb

@@ -14,6 +14,10 @@ class Config < CC::Service::Config
 
   def receive_test
     notify("Test", repo_name, formatter.format_test)
+
+    { ok: true, message: "Test message sent" }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_coverage

lib/cc/services/github_issues.rb

@@ -20,7 +20,14 @@ class Config < CC::Service::Config
   BASE_URL = "https://api.github.com"
 
   def receive_test
-    create_issue("Test ticket from Code Climate", "")
+    result = create_issue("Test ticket from Code Climate", "")
+
+    {
+      ok: true,
+      message: "Issue <a href='#{result[:url]}'>##{result[:number]}</a> created."
+    }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_quality

lib/cc/services/github_pull_requests.rb

@@ -28,7 +28,9 @@ def receive_test
 
     http_get("#{BASE_URL}")
 
-    nil
+    { ok: true, message: "OAuth token is valid" }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_pull_request

lib/cc/services/hipchat.rb

@@ -19,6 +19,10 @@ class Config < CC::Service::Config
 
   def receive_test
     speak(formatter.format_test, "green")
+
+    { ok: true, message: "Test message sent" }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_coverage

lib/cc/services/jira.rb

@@ -29,7 +29,14 @@ class Config < CC::Service::Config
   self.issue_tracker = true
 
   def receive_test
-    create_ticket("Test ticket from Code Climate", "")
+    result = create_ticket("Test ticket from Code Climate", "")
+
+    {
+      ok: true,
+      message: "Ticked <a href='#{result[:url]}'>#{result[:id]}</a> created."
+    }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_quality

lib/cc/services/lighthouse.rb

@@ -23,7 +23,14 @@ class Config < CC::Service::Config
   self.issue_tracker = true
 
   def receive_test
-    create_ticket("Test ticket from Code Climate", "")
+    result = create_ticket("Test ticket from Code Climate", "")
+
+    {
+      ok: true,
+      message: "Ticked <a href='#{result[:url]}'>#{result[:id]}</a> created."
+    }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_quality

lib/cc/services/pivotal_tracker.rb

@@ -21,7 +21,14 @@ class Config < CC::Service::Config
   BASE_URL = "https://www.pivotaltracker.com/services/v3"
 
   def receive_test
-    create_story("Test ticket from Code Climate", "")
+    result = create_story("Test ticket from Code Climate", "")
+
+    {
+      ok: true,
+      message: "Ticked <a href='#{result[:url]}'>#{result[:id]}</a> created."
+    }
+  rescue => ex
+    { ok: false, message: ex.message }
   end
 
   def receive_quality