Ensure statsd keys do not have slashes in them

Author: noahd1

codeclimate-services.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", ">= 1.6.2"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "test-unit"
+  spec.add_development_dependency "mocha"
 end

lib/cc/service/invocation/with_metrics.rb

@@ -30,7 +30,8 @@ def timing_key
     end
 
     def error_key(ex)
-      ["services.errors", @prefix, "#{ex.class.name.underscore}"].compact.join('.')
+      error_string = ex.class.name.underscore.gsub("/", "-")
+      ["services.errors", @prefix, error_string].compact.join('.')
     end
   end
 end

test/helper.rb

@@ -1,4 +1,5 @@
 require 'test/unit'
+require 'mocha/test_unit'
 require 'pp'
 
 require "codeclimate-test-reporter"

test/with_metrics_test.rb

@@ -0,0 +1,19 @@
+# encoding: UTF-8
+
+require File.expand_path('../helper', __FILE__)
+
+class WithMetrics < CC::Service::TestCase
+
+  class FakeInvocation
+    def call
+      raise CC::Service::HTTPError.new("Whoa", {})
+    end
+  end
+
+  def test_statsd_error_key
+    statsd = Object.new
+    statsd.stubs(:timing)
+    statsd.expects("increment").with("services.errors.githubpullrequests.cc-service-http_error")
+    CC::Service::Invocation::WithMetrics.new(FakeInvocation.new, statsd, "githubpullrequests").call rescue CC::Service::HTTPError
+  end
+end