fix(ta-gql): fill_nan on avg_duration in aggregate

it's possible for the avg_duration to be NaN (which is fine) but I
wasn't taking this into account in the aggregate calculation which
meant that the NaN's were propagating to the total duration and
slowest tests duration so we need to replace them with 0 because
that's effectively what they are

Author: joseph-sentry

graphql_api/tests/test_test_analytics.py

@@ -819,6 +819,17 @@ def test_gql_query_with_new_ta_v1(self, mocker, repository, snapshot):
                     }
                 }
             }
+            flakeAggregates {
+                flakeRate
+                flakeCount
+            }
+            testResultsAggregates {
+                totalDuration
+                slowestTestsDuration
+                totalFails
+                totalSkips
+                totalSlowTests
+            }
             testSuites
             """,
         )
@@ -848,6 +859,20 @@ def test_gql_query_with_new_ta_v1(self, mocker, repository, snapshot):
             "testsuite4",
         ]
 
+        assert result["owner"]["repository"]["testAnalytics"]["flakeAggregates"] == {
+            "flakeRate": (1 / 15),
+            "flakeCount": 1,
+        }
+
+        assert result["owner"]["repository"]["testAnalytics"][
+            "testResultsAggregates"
+        ] == {
+            "totalDuration": 7500.0,
+            "slowestTestsDuration": 2500.0,
+            "totalFails": 50,
+            "totalSkips": 25,
+            "totalSlowTests": 1,
+        }
         storage.delete_file(
             settings.GCS_BUCKET_NAME,
             f"test_analytics/branch_rollups/{repository.repoid}/{repository.branch}.arrow",

graphql_api/types/test_results_aggregates/test_results_aggregates.py

@@ -24,7 +24,7 @@ class TestResultsAggregates:
 
 
 def calculate_aggregates(table: pl.DataFrame) -> pl.DataFrame:
-    return table.select(
+    return table.with_columns(pl.col("avg_duration").fill_nan(0)).select(
         (
             pl.col("avg_duration")
             * (pl.col("total_pass_count") + pl.col("total_fail_count"))