Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Commit 13086fd

Browse files
lvthanh03lvthanh03
committed
Function name clarity ("labels" instead of "tags")
1 parent 00bd746 commit 13086fd

File tree

9 files changed

+27
-27
lines changed

9 files changed

+27
-27
lines changed

‎upload/helpers.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ def get_version_from_headers(headers):
790790
return "unknown-user-agent"
791791

792792

793-
def generate_upload_prometheus_metrics_tags(
793+
def generate_upload_prometheus_metrics_labels(
794794
action,
795795
request,
796796
is_shelter_request,

‎upload/views/bundle_analysis.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
from services.archive import ArchiveService
2727
from services.redis_configuration import get_redis_connection
2828
from timeseries.models import Dataset, MeasurementName
29-
from upload.helpers import dispatch_upload_task, generate_upload_prometheus_metrics_tags
29+
from upload.helpers import dispatch_upload_task, generate_upload_prometheus_metrics_labels
3030
from upload.views.base import ShelterMixin
3131
from upload.views.helpers import get_repository_from_string
3232

@@ -80,7 +80,7 @@ def get_exception_handler(self) -> Callable:
8080
return repo_auth_custom_exception_handler
8181

8282
def post(self, request: HttpRequest) -> Response:
83-
labels = generate_upload_prometheus_metrics_tags(
83+
labels = generate_upload_prometheus_metrics_labels(
8484
action="bundle_analysis",
8585
endpoint="bundle_analysis",
8686
request=self.request,
@@ -171,7 +171,7 @@ def post(self, request: HttpRequest) -> Response:
171171
task_arguments=task_arguments,
172172
),
173173
)
174-
labels = generate_upload_prometheus_metrics_tags(
174+
labels = generate_upload_prometheus_metrics_labels(
175175
action="bundle_analysis",
176176
endpoint="bundle_analysis",
177177
request=self.request,

‎upload/views/commits.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
repo_auth_custom_exception_handler,
1515
)
1616
from core.models import Commit
17-
from upload.helpers import generate_upload_prometheus_metrics_tags
17+
from upload.helpers import generate_upload_prometheus_metrics_labels
1818
from upload.metrics import API_UPLOAD_COUNTER
1919
from upload.serializers import CommitSerializer
2020
from upload.views.base import GetterMixin
@@ -56,7 +56,7 @@ def create(self, request, *args, **kwargs):
5656
def perform_create(self, serializer):
5757
inc_counter(
5858
API_UPLOAD_COUNTER,
59-
labels=generate_upload_prometheus_metrics_tags(
59+
labels=generate_upload_prometheus_metrics_labels(
6060
action="coverage",
6161
endpoint="create_commit",
6262
request=self.request,
@@ -75,7 +75,7 @@ def perform_create(self, serializer):
7575

7676
inc_counter(
7777
API_UPLOAD_COUNTER,
78-
labels=generate_upload_prometheus_metrics_tags(
78+
labels=generate_upload_prometheus_metrics_labels(
7979
action="coverage",
8080
endpoint="create_commit",
8181
request=self.request,

‎upload/views/empty_upload.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from services.task import TaskService
2424
from services.yaml import final_commit_yaml
2525
from upload.helpers import (
26-
generate_upload_prometheus_metrics_tags,
26+
generate_upload_prometheus_metrics_labels,
2727
try_to_get_best_possible_bot_token,
2828
)
2929
from upload.metrics import API_UPLOAD_COUNTER
@@ -85,7 +85,7 @@ def get_exception_handler(self):
8585
def post(self, request, *args, **kwargs):
8686
inc_counter(
8787
API_UPLOAD_COUNTER,
88-
labels=generate_upload_prometheus_metrics_tags(
88+
labels=generate_upload_prometheus_metrics_labels(
8989
action="coverage",
9090
endpoint="empty_upload",
9191
request=self.request,
@@ -152,7 +152,7 @@ def post(self, request, *args, **kwargs):
152152
]
153153
inc_counter(
154154
API_UPLOAD_COUNTER,
155-
labels=generate_upload_prometheus_metrics_tags(
155+
labels=generate_upload_prometheus_metrics_labels(
156156
action="coverage",
157157
endpoint="empty_upload",
158158
request=self.request,

‎upload/views/legacy.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
determine_upload_commit_to_use,
3232
determine_upload_pr_to_use,
3333
dispatch_upload_task,
34-
generate_upload_prometheus_metrics_tags,
34+
generate_upload_prometheus_metrics_labels,
3535
insert_commit,
3636
parse_headers,
3737
parse_params,
@@ -77,7 +77,7 @@ def post(self, request, *args, **kwargs):
7777
version = self.kwargs["version"]
7878
inc_counter(
7979
API_UPLOAD_COUNTER,
80-
labels=generate_upload_prometheus_metrics_tags(
80+
labels=generate_upload_prometheus_metrics_labels(
8181
action="coverage",
8282
endpoint="legacy_upload",
8383
request=self.request,
@@ -167,7 +167,7 @@ def post(self, request, *args, **kwargs):
167167

168168
inc_counter(
169169
API_UPLOAD_COUNTER,
170-
labels=generate_upload_prometheus_metrics_tags(
170+
labels=generate_upload_prometheus_metrics_labels(
171171
action="coverage",
172172
endpoint="legacy_upload",
173173
request=self.request,

‎upload/views/reports.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
)
1717
from reports.models import CommitReport, ReportResults
1818
from services.task import TaskService
19-
from upload.helpers import generate_upload_prometheus_metrics_tags
19+
from upload.helpers import generate_upload_prometheus_metrics_labels
2020
from upload.metrics import API_UPLOAD_COUNTER
2121
from upload.serializers import CommitReportSerializer, ReportResultsSerializer
2222
from upload.views.base import GetterMixin
@@ -43,7 +43,7 @@ def get_exception_handler(self):
4343
def perform_create(self, serializer):
4444
inc_counter(
4545
API_UPLOAD_COUNTER,
46-
labels=generate_upload_prometheus_metrics_tags(
46+
labels=generate_upload_prometheus_metrics_labels(
4747
action="coverage",
4848
endpoint="create_report",
4949
request=self.request,
@@ -71,7 +71,7 @@ def perform_create(self, serializer):
7171

7272
inc_counter(
7373
API_UPLOAD_COUNTER,
74-
labels=generate_upload_prometheus_metrics_tags(
74+
labels=generate_upload_prometheus_metrics_labels(
7575
action="coverage",
7676
endpoint="create_report",
7777
request=self.request,
@@ -108,7 +108,7 @@ def get_exception_handler(self):
108108
def perform_create(self, serializer):
109109
inc_counter(
110110
API_UPLOAD_COUNTER,
111-
labels=generate_upload_prometheus_metrics_tags(
111+
labels=generate_upload_prometheus_metrics_labels(
112112
action="coverage",
113113
endpoint="create_report_results",
114114
request=self.request,
@@ -134,7 +134,7 @@ def perform_create(self, serializer):
134134
)
135135
inc_counter(
136136
API_UPLOAD_COUNTER,
137-
labels=generate_upload_prometheus_metrics_tags(
137+
labels=generate_upload_prometheus_metrics_labels(
138138
action="coverage",
139139
endpoint="create_report_results",
140140
request=self.request,

‎upload/views/test_results.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
from reports.models import CommitReport
2424
from services.archive import ArchiveService, MinioEndpoints
2525
from services.redis_configuration import get_redis_connection
26-
from upload.helpers import dispatch_upload_task, generate_upload_prometheus_metrics_tags
26+
from upload.helpers import dispatch_upload_task, generate_upload_prometheus_metrics_labels
2727
from upload.metrics import API_UPLOAD_COUNTER
2828
from upload.serializers import FlagListField
2929
from upload.views.base import ShelterMixin
@@ -69,7 +69,7 @@ def get_exception_handler(self):
6969
def post(self, request):
7070
inc_counter(
7171
API_UPLOAD_COUNTER,
72-
labels=generate_upload_prometheus_metrics_tags(
72+
labels=generate_upload_prometheus_metrics_labels(
7373
action="test_results",
7474
endpoint="test_results",
7575
request=request,
@@ -110,7 +110,7 @@ def post(self, request):
110110

111111
inc_counter(
112112
API_UPLOAD_COUNTER,
113-
labels=generate_upload_prometheus_metrics_tags(
113+
labels=generate_upload_prometheus_metrics_labels(
114114
action="test_results",
115115
endpoint="test_results",
116116
request=request,

‎upload/views/upload_completion.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
)
1515
from reports.models import ReportSession
1616
from services.task import TaskService
17-
from upload.helpers import generate_upload_prometheus_metrics_tags
17+
from upload.helpers import generate_upload_prometheus_metrics_labels
1818
from upload.metrics import API_UPLOAD_COUNTER
1919
from upload.views.base import GetterMixin
2020
from upload.views.uploads import CanDoCoverageUploadsPermission
@@ -37,7 +37,7 @@ def get_exception_handler(self):
3737
def post(self, request, *args, **kwargs):
3838
inc_counter(
3939
API_UPLOAD_COUNTER,
40-
labels=generate_upload_prometheus_metrics_tags(
40+
labels=generate_upload_prometheus_metrics_labels(
4141
action="coverage",
4242
endpoint="upload_complete",
4343
request=self.request,
@@ -81,7 +81,7 @@ def post(self, request, *args, **kwargs):
8181
TaskService().manual_upload_completion_trigger(repo.repoid, commit.commitid)
8282
inc_counter(
8383
API_UPLOAD_COUNTER,
84-
labels=generate_upload_prometheus_metrics_tags(
84+
labels=generate_upload_prometheus_metrics_labels(
8585
action="coverage",
8686
endpoint="upload_complete",
8787
request=self.request,

‎upload/views/uploads.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from services.redis_configuration import get_redis_connection
2929
from upload.helpers import (
3030
dispatch_upload_task,
31-
generate_upload_prometheus_metrics_tags,
31+
generate_upload_prometheus_metrics_labels,
3232
validate_activated_repo,
3333
)
3434
from upload.metrics import API_UPLOAD_COUNTER
@@ -70,7 +70,7 @@ def get_exception_handler(self):
7070
def perform_create(self, serializer: UploadSerializer):
7171
inc_counter(
7272
API_UPLOAD_COUNTER,
73-
labels=generate_upload_prometheus_metrics_tags(
73+
labels=generate_upload_prometheus_metrics_labels(
7474
action="coverage",
7575
endpoint="create_upload",
7676
request=self.request,
@@ -131,7 +131,7 @@ def perform_create(self, serializer: UploadSerializer):
131131
self.trigger_upload_task(repository, commit.commitid, instance, report)
132132
inc_counter(
133133
API_UPLOAD_COUNTER,
134-
labels=generate_upload_prometheus_metrics_tags(
134+
labels=generate_upload_prometheus_metrics_labels(
135135
action="coverage",
136136
endpoint="create_upload",
137137
request=self.request,

0 commit comments

Comments
 (0)