feat: add total slow tests field to testResultsAggregates

Author: joseph-sentry

graphql_api/tests/test_test_analytics.py

@@ -662,17 +662,19 @@ def test_test_results_aggregates(self) -> None:
             )
         res = self.fetch_test_analytics(
             repo.name,
-            """testResultsAggregates { totalDuration, slowestTestsDuration, totalFails, totalSkips, totalDurationPercentChange, slowestTestsDurationPercentChange, totalFailsPercentChange, totalSkipsPercentChange }""",
+            """testResultsAggregates { totalDuration, slowestTestsDuration, totalFails, totalSkips, totalSlowTests, totalDurationPercentChange, slowestTestsDurationPercentChange, totalFailsPercentChange, totalSkipsPercentChange, totalSlowTestsPercentChange }""",
         )
         assert res["testResultsAggregates"] == {
             "totalDuration": 570.0,
-            "slowestTestsDuration": 29.0,
-            "totalFails": 10,
-            "totalSkips": 5,
             "totalDurationPercentChange": -63.1068,
+            "slowestTestsDuration": 29.0,
             "slowestTestsDurationPercentChange": -50.84746,
+            "totalFails": 10,
             "totalFailsPercentChange": 100.0,
+            "totalSkips": 5,
             "totalSkipsPercentChange": -50.0,
+            "totalSlowTests": 1,
+            "totalSlowTestsPercentChange": 0.0,
         }
 
     def test_test_results_aggregates_no_history(self) -> None:
@@ -696,18 +698,20 @@ def test_test_results_aggregates_no_history(self) -> None:
 
         res = self.fetch_test_analytics(
             repo.name,
-            """testResultsAggregates { totalDuration, slowestTestsDuration, totalFails, totalSkips, totalDurationPercentChange, slowestTestsDurationPercentChange, totalFailsPercentChange, totalSkipsPercentChange }""",
+            """testResultsAggregates { totalDuration, slowestTestsDuration, totalFails, totalSkips, totalSlowTests, totalDurationPercentChange, slowestTestsDurationPercentChange, totalFailsPercentChange, totalSkipsPercentChange, totalSlowTestsPercentChange }""",
         )
 
         assert res["testResultsAggregates"] == {
             "totalDuration": 570.0,
-            "slowestTestsDuration": 29.0,
-            "totalFails": 10,
-            "totalSkips": 5,
             "totalDurationPercentChange": None,
+            "slowestTestsDuration": 29.0,
             "slowestTestsDurationPercentChange": None,
+            "totalFails": 10,
             "totalFailsPercentChange": None,
+            "totalSkips": 5,
             "totalSkipsPercentChange": None,
+            "totalSlowTests": 1,
+            "totalSlowTestsPercentChange": None,
         }
 
     def test_flake_aggregates(self) -> None:

graphql_api/types/test_results_aggregates/test_results_aggregates.graphql

@@ -7,4 +7,6 @@ type TestResultsAggregates {
   totalFailsPercentChange: Float
   totalSkips: Int!
   totalSkipsPercentChange: Float
+  totalSlowTests: Int!
+  totalSlowTestsPercentChange: Float
 }

utils/test_results.py

@@ -264,6 +264,7 @@ def get_test_results_aggregate_numbers(
         slowest_tests_duration=slowest_tests_duration,
         skips=Sum("skip_count"),
         fails=Sum("fail_count"),
+        total_slow_tests=Value(slow_test_threshold(num_tests)),
     )
 
     return test_headers[0] if len(test_headers) > 0 else {}
@@ -282,7 +283,13 @@ def generate_test_results_aggregates(
     past_numbers = get_test_results_aggregate_numbers(repo, double_time_ago, since)
 
     return curr_numbers | get_percent_change(
-        ["total_duration", "slowest_tests_duration", "skips", "fails"],
+        [
+            "total_duration",
+            "slowest_tests_duration",
+            "skips",
+            "fails",
+            "total_slow_tests",
+        ],
         curr_numbers,
         past_numbers,
     )