fix: Fix query for is_first_pull_request

Author: suejung-sentry

graphql_api/tests/test_repository.py

@@ -513,6 +513,11 @@ def test_repository_is_first_pull_request(self) -> None:
 
         assert data["me"]["owner"]["repository"]["isFirstPullRequest"] == True
 
+        assert (
+            repo.pulls.values("id")[:2].query
+            == 'SELECT "pulls"."id" FROM "pulls" WHERE "pulls"."repoid" = 1 ORDER BY "pulls"."pullid" DESC LIMIT 2'
+        )
+
     def test_repository_is_first_pull_request_compared_to_not_none(self) -> None:
         repo = RepositoryFactory(
             author=self.owner,

graphql_api/types/repository/repository.py

@@ -14,9 +14,7 @@
 from graphql_api.actions.commits import repo_commits
 from graphql_api.dataloader.commit import CommitLoader
 from graphql_api.dataloader.owner import OwnerLoader
-from graphql_api.helpers.connection import (
-    queryset_to_connection,
-)
+from graphql_api.helpers.connection import queryset_to_connection
 from graphql_api.types.coverage_analytics.coverage_analytics import (
     CoverageAnalyticsProps,
 )
@@ -267,13 +265,16 @@ def resolve_repository_result_type(obj: Any, *_: Any) -> Optional[str]:
 def resolve_is_first_pull_request(
     repository: Repository, info: GraphQLResolveInfo
 ) -> bool:
-    has_one_pr = repository.pull_requests.count() == 1
-
-    if has_one_pr:
-        first_pr = repository.pull_requests.first()
-        return not first_pr.compared_to
-
-    return False
+    try:
+        # SELECT "pulls"."id" FROM "pulls" WHERE "pulls"."repoid" = 1 ORDER BY "pulls"."pullid" DESC LIMIT 2
+        pull_requests = repository.pulls.values("id")[:2]
+        return len(pull_requests) == 1
+    except Exception as e:
+        log.error(
+            "Error checking is_first_pull_request",
+            extra=dict(repo_id=repository.repoid, error=str(e)),
+        )
+        return False
 
 
 @repository_bindable.field("isGithubRateLimited")