Use shared report_service and test factories

This switches most of the code using the `report_builder` service to use that same code imported from `shared` (except some functions specific to `api`).

Similarly, the `core.tests.factories` were also duplicated in shared, so this switches over to those factories, deleting them from `api`.

Author: Swatinem

api/internal/commit/serializers.py

@@ -1,9 +1,9 @@
 import logging
 
+import shared.reports.api_report_service as report_service
 from rest_framework import serializers
 from shared.reports.types import TOTALS_MAP
 
-import services.report as report_service
 from api.internal.owner.serializers import OwnerSerializer
 from api.shared.commit.serializers import CommitTotalsSerializer
 from core.models import Commit

api/internal/tests/test_charts.py

@@ -13,6 +13,7 @@
 from pytz import UTC
 from rest_framework.exceptions import ValidationError
 from rest_framework.reverse import reverse
+from shared.django_apps.core.tests.factories import OwnerFactory, RepositoryFactory
 
 from api.internal.chart.filters import apply_default_filters, apply_simple_filters
 from api.internal.chart.helpers import (
@@ -23,7 +24,6 @@
 )
 from codecov.tests.base_test import InternalAPITest
 from core.models import Commit
-from core.tests.factories import OwnerFactory, RepositoryFactory
 from utils.test_utils import Client
 
 fake = faker.Faker()

api/internal/tests/test_permissions.py

@@ -2,14 +2,14 @@
 
 from django.test import TestCase, override_settings
 from rest_framework.exceptions import APIException
+from shared.django_apps.core.tests.factories import RepositoryFactory
 
 from api.internal.tests.test_utils import (
     GetAdminErrorProviderAdapter,
     GetAdminProviderAdapter,
 )
 from api.shared.permissions import RepositoryPermissionsService, UserIsAdminPermissions
 from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import RepositoryFactory
 
 
 class MockedPermissionsAdapter:

api/internal/tests/test_repo_accessors.py

@@ -1,11 +1,11 @@
 from unittest.mock import patch
 
 from django.test import TestCase
+from shared.django_apps.core.tests.factories import RepositoryFactory
 from shared.torngit.exceptions import TorngitClientError, TorngitClientGeneralError
 
 from api.shared.repo.repository_accessors import RepoAccessors
 from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import RepositoryFactory
 
 
 class RepositoryAccessorsTestCase(TestCase):

api/internal/tests/test_views.py

@@ -3,15 +3,15 @@
 
 from rest_framework import status
 from rest_framework.reverse import reverse
-
-from codecov.tests.base_test import InternalAPITest
-from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import (
+from shared.django_apps.core.tests.factories import (
     BranchFactory,
     CommitFactory,
     PullFactory,
     RepositoryFactory,
 )
+
+from codecov.tests.base_test import InternalAPITest
+from codecov_auth.tests.factories import OwnerFactory
 from utils.test_utils import Client
 
 get_permissions_method = (

api/internal/tests/unit/views/test_compare_flags_view.py

@@ -2,10 +2,14 @@
 from unittest.mock import PropertyMock, patch
 
 from rest_framework.reverse import reverse
+from shared.django_apps.core.tests.factories import (
+    CommitWithReportFactory,
+    PullFactory,
+    RepositoryFactory,
+)
 from shared.reports.types import ReportTotals
 
 from codecov.tests.base_test import InternalAPITest
-from core.tests.factories import CommitWithReportFactory, PullFactory, RepositoryFactory
 
 current_file = Path(__file__)
 
@@ -83,8 +87,7 @@ def test_compare_flags___success(
         )
 
         assert response.status_code == 200
-
-        expected_result = [
+        assert response.data == [
             {
                 "name": "unittests",
                 "base_report_totals": {
@@ -189,18 +192,6 @@ def test_compare_flags___success(
             },
         ]
 
-        assert (
-            response.data[0]["base_report_totals"]
-            == expected_result[0]["base_report_totals"]
-        )
-        assert (
-            response.data[0]["head_report_totals"]
-            == expected_result[0]["head_report_totals"]
-        )
-        assert response.data[0] == expected_result[0]
-        assert response.data[1] == expected_result[1]
-        assert response.data == expected_result
-
     def test_compare_flags_with_report_with_cff_and_non_cff(
         self, diff_totals_mock, read_chunks_mock, git_comparison_mock
     ):
@@ -210,6 +201,12 @@ def test_compare_flags_with_report_with_cff_and_non_cff(
             parent_commit_id=self.parent_commit.commitid,
             repository=self.repo,
         )
+        report = commit_with_custom_reports._report
+        report["sessions"]["0"].update(
+            st="carriedforward",
+            se={"carriedforward_from": "56e05fced214c44a37759efa2dfc25a65d8ae98d"},
+        )
+        commit_with_custom_reports.save()
 
         upload = (
             commit_with_custom_reports.reports.first()
@@ -222,14 +219,6 @@ def test_compare_flags_with_report_with_cff_and_non_cff(
         }
         upload.save()
 
-        upload = (
-            commit_with_custom_reports.reports.first()
-            .sessions.filter(flags__flag_name="integrations")
-            .first()
-        )
-        upload.upload_type = "uploaded"
-        upload.save()
-
         head_chunks = open(
             current_file.parent.parent.parent
             / f"samples/{commit_with_custom_reports.commitid}_chunks.txt",

api/internal/tests/unit/views/test_compare_view.py

@@ -3,17 +3,17 @@
 
 from rest_framework import status
 from rest_framework.reverse import reverse
-
-from api.internal.commit.serializers import CommitTotalsSerializer
-from codecov.tests.base_test import InternalAPITest
-from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import (
+from shared.django_apps.core.tests.factories import (
     BranchFactory,
     CommitWithReportFactory,
     PullFactory,
     RepositoryFactory,
 )
 
+from api.internal.commit.serializers import CommitTotalsSerializer
+from codecov.tests.base_test import InternalAPITest
+from codecov_auth.tests.factories import OwnerFactory
+
 
 def build_commits(client):
     """

api/internal/tests/views/test_compare_viewset.py

@@ -3,28 +3,29 @@
 from rest_framework import status
 from rest_framework.reverse import reverse
 from rest_framework.test import APITestCase
+from shared.django_apps.core.tests.factories import (
+    CommitFactory,
+    PullFactory,
+    RepositoryFactory,
+)
+from shared.reports.api_report_service import SerializableReport
 from shared.reports.resources import ReportFile
 from shared.reports.types import ReportTotals
 from shared.utils.merge import LineType
 
 import services.comparison as comparison
 from api.shared.commit.serializers import ReportTotalsSerializer
 from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import CommitFactory, PullFactory, RepositoryFactory
-from services.report import SerializableReport
 from utils.test_utils import Client
 
 
 class MockSerializableReport(SerializableReport):
     """
-    Stubs the 'file_reports' and 'get' methods of SerializableReport, which usually constructs
+    Stubs the 'get' method of SerializableReport, which usually constructs
     report files on the fly from information not provided by these test, like the chunks
     for example.
     """
 
-    def file_reports(self):
-        return [report_file for name, report_file in self.mocked_files.items()]
-
     def get(self, file_name):
         return self.mocked_files.get(file_name)
 

api/internal/tests/views/test_coverage_viewset.py

@@ -4,11 +4,15 @@
 from django.db import connection
 from rest_framework.reverse import reverse
 from rest_framework.test import APITestCase
+from shared.django_apps.core.tests.factories import (
+    BranchFactory,
+    CommitFactory,
+    RepositoryFactory,
+)
 from shared.reports.resources import Report, ReportFile, ReportLine
 from shared.utils.sessions import Session
 
 from codecov_auth.tests.factories import OwnerFactory
-from core.tests.factories import BranchFactory, CommitFactory, RepositoryFactory
 from services.components import Component
 from utils.test_utils import Client