Publish GH App Installed event

Author: spalmurray

webhook_handlers/tests/test_github.py

@@ -583,6 +583,84 @@ def test_installation_creates_new_owner_if_dne_default_app(self, mock_refresh):
             repos_affected=[("12321", "R_kgDOG2tZYQ"), ("12343", "R_kgDOG2tABC")],
         )
 
+    @patch("shared.events.amplitude.AmplitudeEventPublisher.publish")
+    @patch("services.task.TaskService.refresh")
+    def test_installation_publishes_amplitude_event_without_installer(
+        self, mock_refresh, mock_amplitude_publish
+    ):
+        username, service_id = "newuser", 123456
+
+        self._post_event_data(
+            event=GitHubWebhookEvents.INSTALLATION,
+            data={
+                "installation": {
+                    "id": 4,
+                    "repository_selection": "selected",
+                    "account": {"id": service_id, "login": username},
+                    "app_id": DEFAULT_APP_ID,
+                },
+                "repositories": [
+                    {"id": "12321", "node_id": "R_kgDOG2tZYQ"},
+                    {"id": "12343", "node_id": "R_kgDOG2tABC"},
+                ],
+                "sender": {"type": "User"},
+            },
+        )
+
+        owner_set = Owner.objects.filter(
+            service="github", service_id=service_id, username=username
+        )
+        assert owner_set.exists()
+        owner = owner_set.first()
+
+        mock_amplitude_publish.assert_called_with(
+            "App Installed",
+            {
+                "user_ownerid": owner.ownerid,
+                "ownerid": owner.ownerid,
+            },
+        )
+
+    @patch("shared.events.amplitude.AmplitudeEventPublisher.publish")
+    @patch("services.task.TaskService.refresh")
+    def test_installation_publishes_amplitude_event_with_installer(
+        self, mock_refresh, mock_amplitude_publish
+    ):
+        installer = OwnerFactory(service="github", username="installer_username")
+
+        username, service_id = "newuser", 123456
+
+        self._post_event_data(
+            event=GitHubWebhookEvents.INSTALLATION,
+            data={
+                "installation": {
+                    "id": 4,
+                    "repository_selection": "selected",
+                    "account": {"id": service_id, "login": username},
+                    "app_id": DEFAULT_APP_ID,
+                },
+                "repositories": [
+                    {"id": "12321", "node_id": "R_kgDOG2tZYQ"},
+                    {"id": "12343", "node_id": "R_kgDOG2tABC"},
+                ],
+                "sender": {"type": "User", "login": "installer_username"},
+            },
+        )
+
+        owner_set = Owner.objects.filter(
+            service="github", service_id=service_id, username=username
+        )
+        assert owner_set.exists()
+        owner = owner_set.first()
+
+        mock_amplitude_publish.assert_called_with(
+            "App Installed",
+            {
+                "user_ownerid": installer.ownerid,
+                "ownerid": owner.ownerid,
+            },
+        )
+
     @patch(
         "services.task.TaskService.refresh",
         lambda self,

webhook_handlers/views/github.py

@@ -13,6 +13,7 @@
 from rest_framework.permissions import AllowAny
 from rest_framework.response import Response
 from rest_framework.views import APIView
+from shared.events.amplitude import AmplitudeEventPublisher
 
 from codecov_auth.models import (
     GITHUB_APP_INSTALLATION_DEFAULT_NAME,
@@ -498,9 +499,34 @@ def _handle_installation_events(
             # GithubWebhookEvents.INSTALLTION_REPOSITORIES also execute this code
             # because of deprecated flow. But the GithubAppInstallation shouldn't be changed
             if event == GitHubWebhookEvents.INSTALLATION:
-                ghapp_installation, _ = GithubAppInstallation.objects.get_or_create(
-                    installation_id=installation_id, owner=owner
+                ghapp_installation, was_created = (
+                    GithubAppInstallation.objects.get_or_create(
+                        installation_id=installation_id, owner=owner
+                    )
                 )
+                if was_created:
+                    installer_username = request.data.get("sender", {}).get(
+                        "login", None
+                    )
+                    installer = (
+                        Owner.objects.filter(
+                            service=self.service_name,
+                            username=installer_username,
+                        ).first()
+                        if installer_username
+                        else None
+                    )
+                    # If installer does not exist, just attribute the action to the org owner.
+                    AmplitudeEventPublisher().publish(
+                        "App Installed",
+                        {
+                            "user_ownerid": installer.ownerid
+                            if installer is not None
+                            else owner.ownerid,
+                            "ownerid": owner.ownerid,
+                        },
+                    )
+
                 app_id = request.data["installation"]["app_id"]
                 # Either update or set
                 # But this value shouldn't change for the installation, so doesn't matter