add metrics in upload urls to better match ongoing + changing shelter… (#737)

Author: adrian-codecov

upload/tests/views/test_bundle_analysis.py

@@ -98,6 +98,7 @@ def test_upload_bundle_analysis_success(db, client, mocker, mock_redis):
             "endpoint": "bundle_analysis",
             "repo_visibility": "private",
             "is_using_shelter": "no",
+            "position": "end",
         },
     )
 

upload/tests/views/test_empty_upload.py

@@ -99,6 +99,7 @@ def test_empty_upload_with_yaml_ignored_files(
             "endpoint": "empty_upload",
             "repo_visibility": "private",
             "is_using_shelter": "no",
+            "position": "end",
         },
     )
 

upload/tests/views/test_reports.py

@@ -312,6 +312,7 @@ def test_reports_results_post_successful_github_oidc_auth(
             "endpoint": "create_report_results",
             "repo_visibility": "private",
             "is_using_shelter": "no",
+            "position": "end",
         },
     )
 

upload/tests/views/test_test_results.py

@@ -102,6 +102,7 @@ def test_upload_test_results(db, client, mocker, mock_redis):
             "endpoint": "test_results",
             "repo_visibility": "private",
             "is_using_shelter": "no",
+            "position": "end",
         },
     )
 

upload/tests/views/test_upload_completion.py

@@ -97,6 +97,7 @@ def test_upload_completion_view_processed_uploads(mocked_manual_trigger, db, moc
             "endpoint": "upload_complete",
             "repo_visibility": "private",
             "is_using_shelter": "no",
+            "position": "end",
         },
     )
 

upload/views/bundle_analysis.py

@@ -61,6 +61,16 @@ def get_exception_handler(self) -> Callable:
         return repo_auth_custom_exception_handler
 
     def post(self, request: HttpRequest) -> Response:
+        sentry_metrics.incr(
+            "upload",
+            tags=generate_upload_sentry_metrics_tags(
+                action="bundle_analysis",
+                endpoint="bundle_analysis",
+                request=self.request,
+                is_shelter_request=self.is_shelter_request(),
+                position="start",
+            ),
+        )
         serializer = UploadSerializer(data=request.data)
         if not serializer.is_valid():
             return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
@@ -136,12 +146,6 @@ def post(self, request: HttpRequest) -> Response:
             ),
         )
 
-        dispatch_upload_task(
-            task_arguments,
-            repo,
-            get_redis_connection(),
-            report_type=CommitReport.ReportType.BUNDLE_ANALYSIS,
-        )
         sentry_metrics.incr(
             "upload",
             tags=generate_upload_sentry_metrics_tags(
@@ -150,9 +154,17 @@ def post(self, request: HttpRequest) -> Response:
                 request=self.request,
                 repository=repo,
                 is_shelter_request=self.is_shelter_request(),
+                position="end",
             ),
         )
 
+        dispatch_upload_task(
+            task_arguments,
+            repo,
+            get_redis_connection(),
+            report_type=CommitReport.ReportType.BUNDLE_ANALYSIS,
+        )
+
         if settings.TIMESERIES_ENABLED:
             supported_bundle_analysis_measurement_types = [
                 MeasurementName.BUNDLE_ANALYSIS_ASSET_SIZE,

upload/views/empty_upload.py

@@ -81,6 +81,16 @@ def get_exception_handler(self):
         return repo_auth_custom_exception_handler
 
     def post(self, request, *args, **kwargs):
+        sentry_metrics.incr(
+            "upload",
+            tags=generate_upload_sentry_metrics_tags(
+                action="coverage",
+                endpoint="empty_upload",
+                request=self.request,
+                is_shelter_request=self.is_shelter_request(),
+                position="start",
+            ),
+        )
         serializer = EmptyUploadSerializer(data=request.data)
         if not serializer.is_valid():
             return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
@@ -141,6 +151,7 @@ def post(self, request, *args, **kwargs):
                 request=self.request,
                 repository=repo,
                 is_shelter_request=self.is_shelter_request(),
+                position="end",
             ),
         )
         if set(changed_files) == set(ignored_changed_files):

upload/views/reports.py

@@ -101,12 +101,13 @@ def get_exception_handler(self):
 
     def perform_create(self, serializer):
         sentry_metrics.incr(
-            "upload_start",
+            "upload",
             tags=generate_upload_sentry_metrics_tags(
                 action="coverage",
                 endpoint="create_report_results",
                 request=self.request,
                 is_shelter_request=self.is_shelter_request(),
+                position="start",
             ),
         )
         repository = self.get_repo()
@@ -133,6 +134,7 @@ def perform_create(self, serializer):
                 request=self.request,
                 repository=repository,
                 is_shelter_request=self.is_shelter_request(),
+                position="end",
             ),
         )
         return instance

upload/views/test_results.py

@@ -64,6 +64,16 @@ def get_exception_handler(self):
         return repo_auth_custom_exception_handler
 
     def post(self, request):
+        metrics.incr(
+            "upload",
+            tags=generate_upload_sentry_metrics_tags(
+                action="test_results",
+                endpoint="test_results",
+                request=request,
+                is_shelter_request=self.is_shelter_request(),
+                position="start",
+            ),
+        )
         serializer = UploadSerializer(data=request.data)
         if not serializer.is_valid():
             return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)
@@ -100,6 +110,7 @@ def post(self, request):
                 request=request,
                 repository=repo,
                 is_shelter_request=self.is_shelter_request(),
+                position="end",
             ),
         )
 

upload/views/upload_completion.py

@@ -34,6 +34,16 @@ def get_exception_handler(self):
         return repo_auth_custom_exception_handler
 
     def post(self, request, *args, **kwargs):
+        sentry_metrics.incr(
+            "upload",
+            tags=generate_upload_sentry_metrics_tags(
+                action="coverage",
+                endpoint="upload_complete",
+                request=self.request,
+                is_shelter_request=self.is_shelter_request(),
+                position="start",
+            ),
+        )
         repo = self.get_repo()
         commit = self.get_commit(repo)
         uploads_queryset = ReportSession.objects.filter(
@@ -76,6 +86,7 @@ def post(self, request, *args, **kwargs):
                 request=self.request,
                 repository=repo,
                 is_shelter_request=self.is_shelter_request(),
+                position="end",
             ),
         )
         return Response(