More syntax and lint fixes

Author: lvthanh03

graphql_api/tests/test_views.py

@@ -1,5 +1,5 @@
 import json
-from unittest.mock import Mock, call, patch
+from unittest.mock import Mock, patch
 
 from ariadne import ObjectType, make_executable_schema
 from ariadne.validation import cost_directive

upload/helpers.py

@@ -818,8 +818,6 @@ def generate_upload_prometheus_metrics_tags(
         "upload_version": upload_version,
     }
 
-    for field, value in optional_fields.items():
-        if value or fill_labels:
-            metrics_tags[field] = value
+    metrics_tags.update({field: value for field, value in optional_fields.items() if value or fill_labels})
 
     return metrics_tags

upload/views/commits.py

@@ -2,7 +2,6 @@
 
 from rest_framework.exceptions import NotAuthenticated
 from rest_framework.generics import ListCreateAPIView
-from shared.metrics import Counter
 
 from codecov_auth.authentication.repo_auth import (
     GitHubOIDCTokenAuthentication,

upload/views/legacy.py

@@ -16,7 +16,7 @@
 from rest_framework.exceptions import ValidationError
 from rest_framework.permissions import AllowAny
 from rest_framework.views import APIView
-from shared.metrics import metrics, Counter
+from shared.metrics import metrics
 
 from codecov.db import sync_to_async
 from codecov_auth.commands.owner import OwnerCommands
@@ -45,12 +45,6 @@
 
 log = logging.getLogger(__name__)
 
-API_UPLOAD_COUNTER = Counter(
-    "api_upload",
-    "Number of times API upload endpoint request starts",
-    ["version"],
-)
-
 
 class PlainTextRenderer(renderers.BaseRenderer):
     media_type = "text/plain"