use bytes in test

Author: rohitvinnakota-codecov

api/gen_ai/tests/test_gen_ai.py

@@ -1,5 +1,4 @@
 import hmac
-import json
 from hashlib import sha256
 from unittest.mock import patch
 
@@ -14,20 +13,19 @@
 VIEW_URL = reverse("auth")
 
 
-def sign_payload(payload, secret=PAYLOAD_SECRET):
-    data = json.dumps(payload, separators=(",", ":")).encode("utf-8")
+def sign_payload(data: bytes, secret=PAYLOAD_SECRET):
     signature = "sha256=" + hmac.new(secret, data, digestmod=sha256).hexdigest()
     return signature, data
 
 
 class GenAIAuthViewTests(APITestCase):
     @patch("utils.config.get_config", return_value=PAYLOAD_SECRET)
     def test_missing_parameters(self, mock_config):
-        payload = {}
+        payload = b"{}"
         sig, data = sign_payload(payload)
         response = self.client.post(
             VIEW_URL,
-            data=payload,
+            data=data,
             content_type="application/json",
             HTTP_HTTP_X_GEN_AI_AUTH_SIGNATURE=sig,
         )
@@ -36,11 +34,10 @@ def test_missing_parameters(self, mock_config):
 
     @patch("utils.config.get_config", return_value=PAYLOAD_SECRET)
     def test_invalid_signature(self, mock_config):
-        payload = {"external_owner_id": "owner1", "repo_service_id": "101"}
-        # Create a wrong signature by altering the payload before signing
-        wrong_sig = (
-            "sha256=" + hmac.new(PAYLOAD_SECRET, b"{}", digestmod=sha256).hexdigest()
-        )
+        # Correct payload
+        payload = b'{"external_owner_id":"owner1","repo_service_id":"101"}'
+        # Wrong signature based on a different payload
+        wrong_sig = "sha256=" + hmac.new(PAYLOAD_SECRET, b"{}", sha256).hexdigest()
         response = self.client.post(
             VIEW_URL,
             data=payload,
@@ -51,42 +48,41 @@ def test_invalid_signature(self, mock_config):
 
     @patch("utils.config.get_config", return_value=PAYLOAD_SECRET)
     def test_owner_not_found(self, mock_config):
-        payload = {"external_owner_id": "nonexistent_owner", "repo_service_id": "101"}
-        sig, serialized_data = sign_payload(payload)
+        payload = b'{"external_owner_id":"nonexistent_owner","repo_service_id":"101"}'
+        sig, data = sign_payload(payload)
         response = self.client.post(
             VIEW_URL,
-            HTTP_HTTP_X_GEN_AI_AUTH_SIGNATURE=sig,
-            data=serialized_data,
+            data=data,
             content_type="application/json",
+            HTTP_HTTP_X_GEN_AI_AUTH_SIGNATURE=sig,
         )
         self.assertEqual(response.status_code, 404)
 
     @patch("utils.config.get_config", return_value=PAYLOAD_SECRET)
     def test_no_installation(self, mock_config):
-        _ = OwnerFactory(service="github", service_id="owner1", username="test1")
-        payload = {"external_owner_id": "owner1", "repo_service_id": "101"}
+        # Create a valid owner but no installation
+        OwnerFactory(service="github", service_id="owner1", username="test1")
+        payload = b'{"external_owner_id":"owner1","repo_service_id":"101"}'
         sig, data = sign_payload(payload)
         response = self.client.post(
             VIEW_URL,
             data=data,
             content_type="application/json",
             HTTP_HTTP_X_GEN_AI_AUTH_SIGNATURE=sig,
         )
-
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, {"is_valid": False})
 
     @patch("utils.config.get_config", return_value=PAYLOAD_SECRET)
     def test_authorized(self, mock_config):
         owner = OwnerFactory(service="github", service_id="owner2", username="test2")
-        app_install = GithubAppInstallation(
+        GithubAppInstallation.objects.create(
             installation_id=12345,
             owner=owner,
             name="ai-features",
             repository_service_ids=["101", "202"],
         )
-        app_install.save()
-        payload = {"external_owner_id": "owner2", "repo_service_id": "101"}
+        payload = b'{"external_owner_id":"owner2","repo_service_id":"101"}'
         sig, data = sign_payload(payload)
         response = self.client.post(
             VIEW_URL,
@@ -100,15 +96,13 @@ def test_authorized(self, mock_config):
     @patch("utils.config.get_config", return_value=PAYLOAD_SECRET)
     def test_unauthorized(self, mock_config):
         owner = OwnerFactory(service="github", service_id="owner3", username="test3")
-        # Create a GithubAppInstallation where the list does not include the requested repo_service_id.
-        app_install = GithubAppInstallation.objects.create(
+        GithubAppInstallation.objects.create(
             installation_id=2,
             owner=owner,
             name="ai-features",
             repository_service_ids=["303", "404"],
         )
-        app_install.save()
-        payload = {"external_owner_id": "owner3", "repo_service_id": "101"}
+        payload = b'{"external_owner_id":"owner3","repo_service_id":"101"}'
         sig, data = sign_payload(payload)
         response = self.client.post(
             VIEW_URL,