feat: Add async linting

Author: suejung-sentry

Makefile

@@ -40,8 +40,10 @@ test.integration:
 	COVERAGE_CORE=sysmon python -m pytest --cov=./ -m "integration" --cov-report=xml:integration.coverage.xml --junitxml=integration.junit.xml -o junit_family=legacy
 
 lint:
-	make lint.install
-	make lint.run
+#	make lint.install
+#	make lint.run
+
+	make mypy-check
 
 lint.install:
 	echo "Installing..."
@@ -57,6 +59,15 @@ lint.check:
 	echo "Formatting..."
 	ruff format --check
 
+
+# Check if mypy and django-stubs are installed and run type checks
+mypy-check:
+	# Install mypy and django-stubs if they aren't already installed
+	pip show mypy > /dev/null || pip install mypy
+	pip show django-stubs > /dev/null || pip install django-stubs
+	# Run mypy with verbose output
+	mypy --config-file mypy.ini .
+
 build.requirements:
 	# if docker pull succeeds, we have already build this version of
 	# requirements.txt.  Otherwise, build and push a version tagged

codecov_auth/tests/unit/views/test_bitbucket_server.py

@@ -30,7 +30,7 @@ def test_get_bbs_redirect(client, settings, mocker):
         == "https://my.bitbucketserver.com/plugins/servlet/oauth/authorize?oauth_token=SomeToken"
     )
     client_request_mock.assert_called_with(
-        "POST", f"{settings.BITBUCKET_SERVER_URL}/plugins/servlet/oauth/request-token"
+        "POST", f"{settings.BITBUCKET_SERVER_URL}/z_plugins/servlet/oauth/request-token"
     )
 
 
@@ -66,11 +66,11 @@ async def fake_list_teams():
 
     async def fake_api(method, url):
         if method == "POST" and (
-            url.endswith("/plugins/servlet/oauth/access-token")
-            or url.endswith("/plugins/servlet/oauth/request-token")
+            url.endswith("/z_plugins/servlet/oauth/access-token")
+            or url.endswith("/z_plugins/servlet/oauth/request-token")
         ):
             return dict(oauth_token="SomeToken", oauth_token_secret="SomeTokenSecret")
-        elif method == "GET" and url.endswith("/plugins/servlet/applinks/whoami"):
+        elif method == "GET" and url.endswith("/z_plugins/servlet/applinks/whoami"):
             return "ThiagoCodecov"
         elif method == "GET" and ("/users/ThiagoCodecov" in url):
             return dict(

graphql_api/types/plan/plan.py

@@ -36,7 +36,6 @@ def resolve_trial_status(plan_service: PlanService, info) -> TrialStatus:
 
 
 @plan_bindable.field("marketingName")
-@sync_to_async
 def resolve_marketing_name(plan_service: PlanService, info) -> str:
     return plan_service.marketing_name
 

mypy.ini

@@ -6,6 +6,12 @@ ignore_missing_imports = True
 disable_error_code = attr-defined,import-untyped,name-defined
 follow_imports = silent
 warn_no_return = False
+plugins = mypy_django_plugin.main
 
 [mypy-*.tests.*]
-disallow_untyped_defs = False
+disallow_untyped_defs = False
+
+# Enable async ORM checks to catch synchronous ORM calls in async functions
+[mypy.plugins.django-stubs]
+enable-async-orm-checks = True
+django_settings_module = "codecov.settings_dev"

requirements.txt

@@ -81,7 +81,7 @@ click==8.1.7
     # via
     #   celery
     #   click-didyoumean
-    #   click-plugins
+    #   click-z_plugins
     #   click-repl
 click-didyoumean==0.3.0
     # via celery

ruff.toml

@@ -36,9 +36,16 @@ indent-width = 4
 target-version = "py312"
 
 [lint]
-# Currently only enabled for F (Pyflakes), I (isort), E,W (pycodestyle:Error/Warning), PLC/PLE (Pylint:Convention/Error) 
-# and PERF (Perflint) rules: https://docs.astral.sh/ruff/rules/
-select = ["F", "I", "E", "W", "PLC", "PLE", "PERF"]
+select = [
+    "ASYNC", # flake8-async - async checks
+    "F", # pyflakes - general Python errors, undefined names
+    "I", # isort - import sorting
+    "E", # pycodestyle - error rules
+    "W", # pycodestyle - warning rules
+    "PLC", # pylint - convention rules
+    "PLE", # pylint - error rules
+    "PERF", # perflint
+]
 ignore = ["F405", "F403", "E501", "E712"]
 
 # Allow fix for all enabled rules (when `--fix`) is provided.