return types

rohitvinnakota-codecov · rohitvinnakota-codecov · commit 3f7f24510600 · 2025-01-31T10:53:38.000-05:00
diff --git a/api/public/v2/pull/serializers.py b/api/public/v2/pull/serializers.py
@@ -54,7 +54,7 @@ def get_patch(self, obj: Pull) -> Optional[Dict[str, float]]:
                 misses += pc.misses
                 partials += pc.partials
         total_branches = hits + misses + partials
-        coverage = 0
+        coverage = 0.0
         if total_branches != 0:
             coverage = round(100 * hits / total_branches, 2)
         data = dict(
diff --git a/services/comparison.py b/services/comparison.py
@@ -1248,7 +1248,7 @@ def _load_commit(self, commit_id: int) -> Optional[Commit]:
         )
 
     @staticmethod
-    def get_commit_comparison_for_pull(obj: Pull):
+    def get_commit_comparison_for_pull(obj: Pull) -> Optional[CommitComparison]:
         comparison_qs = CommitComparison.objects.filter(
             base_commit__commitid=obj.compared_to,
             compare_commit__commitid=obj.head,

Original file line number	Diff line number	Diff line change
`@@ -1248,7 +1248,7 @@ def _load_commit(self, commit_id: int) -> Optional[Commit]:`
`1248`	`1248`	`)`
`1249`	`1249`
`1250`	`1250`	`@staticmethod`
`1251`		`- def get_commit_comparison_for_pull(obj: Pull):`
	`1251`	`+ def get_commit_comparison_for_pull(obj: Pull) -> Optional[CommitComparison]:`
`1252`	`1252`	`comparison_qs = CommitComparison.objects.filter(`
`1253`	`1253`	`base_commit__commitid=obj.compared_to,`
`1254`	`1254`	`compare_commit__commitid=obj.head,`