Update

Author: rohitvinnakota-codecov

webhook_handlers/tests/test_github.py

@@ -61,9 +61,7 @@ def mock_webhook_secret(self, mocker):
 
     @pytest.fixture(autouse=True)
     def mock_ai_features_app_id(self, mocker):
-        mock_config_helper(
-            mocker, configs={"github.ai_features_app_id": AI_FEATURES_GH_APP_ID}
-        )
+        mock_config_helper(mocker, configs={"github.ai_features_app_id": 9999})
 
     @pytest.fixture(autouse=True)
     def mock_default_app_id(self, mocker):
@@ -1456,7 +1454,7 @@ def test_check_codecov_ai_auto_enabled_reviews_enabled(self):
                     },
                 },
             },
-            app_id=AI_FEATURES_GH_APP_ID,
+            app_id=9999,
         )
         assert response.data == {"auto_review_enabled": True}
 
@@ -1478,7 +1476,7 @@ def test_check_codecov_ai_auto_enabled_reviews_disabled(self):
                     "owner": {"id": org_with_ai_disabled.service_id},
                 },
             },
-            app_id=AI_FEATURES_GH_APP_ID,
+            app_id=9999,
         )
         assert response.data == {"auto_review_enabled": False}
 
@@ -1498,7 +1496,7 @@ def test_check_codecov_ai_auto_enabled_reviews_no_config(self):
                     "owner": {"id": org_with_no_config.service_id},
                 },
             },
-            app_id=AI_FEATURES_GH_APP_ID,
+            app_id=9999,
         )
         assert response.data == {"auto_review_enabled": False}
 
@@ -1520,6 +1518,6 @@ def test_check_codecov_ai_auto_enabled_reviews_partial_config(self):
                     "owner": {"id": org_with_partial_config.service_id},
                 },
             },
-            app_id=AI_FEATURES_GH_APP_ID,
+            app_id=9999,
         )
         assert response.data == {"auto_review_enabled": False}

webhook_handlers/views/github.py

@@ -38,7 +38,6 @@
 
 # This should probably go somewhere where it can be easily shared
 regexp_ci_skip = re.compile(r"\[(ci|skip| |-){3,}\]").search
-AI_FEATURES_GH_APP_ID = get_config("github", "ai_features_app_id")
 
 
 class GithubWebhookHandler(APIView):
@@ -53,6 +52,10 @@ class GithubWebhookHandler(APIView):
 
     service_name = "github"
 
+    @property
+    def ai_features_app_id(self):
+        return get_config("github", "ai_features_app_id")
+
     def _inc_recv(self):
         action = self.request.data.get("action", "")
         WEBHOOKS_RECEIVED.labels(
@@ -367,7 +370,7 @@ def status(self, request, *args, **kwargs):
 
     def _is_ai_features_request(self, request):
         target_id = request.META.get(GitHubHTTPHeaders.HOOK_INSTALLATION_TARGET_ID, "")
-        return str(target_id) == str(AI_FEATURES_GH_APP_ID)
+        return str(target_id) == str(self.ai_features_app_id)
 
     def pull_request(self, request, *args, **kwargs):
         if self._is_ai_features_request(request):
@@ -407,17 +410,10 @@ def pull_request(self, request, *args, **kwargs):
         return Response()
 
     def check_codecov_ai_auto_enabled_reviews(self, request):
-        try:
-            org = Owner.objects.get(
-                service=self.service_name,
-                service_id=request.data["repository"]["owner"]["id"],
-            )
-        except Owner.DoesNotExist:
-            return Response(
-                data={
-                    "auto_review_enabled": False,
-                }
-            )
+        org = Owner.objects.get(
+            service=self.service_name,
+            service_id=request.data["repository"]["owner"]["id"],
+        )
 
         auto_review_enabled = org.yaml.get("ai_pr_review", {}).get("auto_review", False)
         return Response(