lint, update with tests

Author: RulaKhaled

codecov_auth/admin.py

@@ -1,15 +1,15 @@
-import csv
 import logging
 from datetime import timedelta
 from typing import Optional, Sequence
+
 import django.forms as forms
 from django.conf import settings
 from django.contrib import admin, messages
 from django.contrib.admin.models import LogEntry
 from django.db.models import OuterRef, Subquery
 from django.db.models.fields import BLANK_CHOICE_DASH
 from django.forms import CheckboxInput, Select, Textarea
-from django.http import HttpRequest, HttpResponse
+from django.http import HttpRequest
 from django.shortcuts import redirect, render
 from django.utils import timezone
 from django.utils.html import format_html
@@ -25,7 +25,7 @@
 
 from codecov.admin import AdminMixin
 from codecov.commands.exceptions import ValidationError
-from codecov_auth.helpers import History
+from codecov_auth.helpers import History, export_to_csv
 from codecov_auth.models import OrganizationLevelToken, Owner, SentryUser, Session, User
 from codecov_auth.services.org_level_token_service import OrgLevelTokenService
 from services.task import TaskService
@@ -734,21 +734,6 @@ class PlansInline(admin.TabularInline):
         Plan._meta.get_field("benefits"): {"widget": Textarea(attrs={"rows": 3})},
     }
 
-def export_to_csv(modeladmin, request, queryset):
-    model = queryset.model
-    response = HttpResponse(content_type="text/csv")
-    response["Content-Disposition"] = f'attachment; filename="{model._meta.model_name}s.csv"'
-    writer = csv.writer(response)
-
-    writer.writerow([field.name for field in model._meta.fields])
-
-    for obj in queryset:
-        writer.writerow([getattr(obj, field.name) for field in model._meta.fields])
-
-    return response
-
-export_to_csv.short_description = "Export selected items to CSV"
-
 
 @admin.register(Tier)
 class TierAdmin(admin.ModelAdmin):

codecov_auth/helpers.py

@@ -1,8 +1,10 @@
+import csv
 from traceback import format_stack
 
 import requests
 from django.contrib.admin.models import CHANGE, LogEntry
 from django.contrib.contenttypes.models import ContentType
+from django.http import HttpResponse
 
 from codecov_auth.constants import GITLAB_BASE_URL
 
@@ -69,3 +71,22 @@ def log(objects, message, user, action_flag=None, add_traceback=False):
                 change_message=message,
                 action_flag=action_flag,
             )
+
+
+def export_to_csv(modeladmin, request, queryset):
+    model = queryset.model
+    response = HttpResponse(content_type="text/csv")
+    response["Content-Disposition"] = (
+        f'attachment; filename="{model._meta.model_name}s.csv"'
+    )
+    writer = csv.writer(response)
+
+    writer.writerow([field.name for field in model._meta.fields])
+
+    for obj in queryset:
+        writer.writerow([getattr(obj, field.name) for field in model._meta.fields])
+
+    return response
+
+
+export_to_csv.short_description = "Export selected items to CSV"

codecov_auth/tests/test_admin.py

@@ -1007,6 +1007,23 @@ def test_plan_change_form_validation(self):
         self.assertEqual(response.status_code, 200)
         self.assertContains(response, "Monthly uploads limit cannot be negative.")
 
+    def test_export_to_csv(self):
+        response = self.client.post(
+            reverse("admin:codecov_auth_plan_changelist"),
+            data={"action": "export_to_csv", ACTION_CHECKBOX_NAME: [self.plan.pk]},
+        )
+        self.assertEqual(response.status_code, 200)
+
+    def test_export_to_csv_with_multiple_selected_items(self):
+        response = self.client.post(
+            reverse("admin:codecov_auth_plan_changelist"),
+            data={
+                "action": "export_to_csv",
+                ACTION_CHECKBOX_NAME: [self.plan.pk, self.tier.pk],
+            },
+        )
+        self.assertEqual(response.status_code, 200)
+
 
 class TierAdminTest(TestCase):
     def setUp(self):
@@ -1051,3 +1068,27 @@ def test_tier_change_form(self):
             "private_repo_support",
         ]:
             self.assertContains(response, f"id_{field}")
+
+    def test_export_to_csv(self):
+        response = self.client.post(
+            reverse("admin:codecov_auth_tier_changelist"),
+            data={"action": "export_to_csv", ACTION_CHECKBOX_NAME: [self.tier.pk]},
+        )
+        self.assertEqual(response.status_code, 200)
+
+    def test_export_to_csv_with_multiple_selected_items(self):
+        response = self.client.post(
+            reverse("admin:codecov_auth_tier_changelist"),
+            data={
+                "action": "export_to_csv",
+                ACTION_CHECKBOX_NAME: [self.tier.pk, self.plan.pk],
+            },
+        )
+        self.assertEqual(response.status_code, 200)
+
+    def test_export_to_csv_with_no_selected_items(self):
+        response = self.client.post(
+            reverse("admin:codecov_auth_tier_changelist"),
+            data={"action": "export_to_csv"},
+        )
+        self.assertEqual(response.status_code, 200)