Track Upload Sent event

Author: spalmurray

upload/tests/views/test_uploads.py

@@ -314,6 +314,7 @@ def test_uploads_post_tokenless(db, mocker, mock_redis, private, branch, branch_
         "upload.views.uploads.trigger_upload_task", return_value=True
     )
     analytics_service_mock = mocker.patch("upload.views.uploads.AnalyticsService")
+    amplitude_mock = mocker.path("shared.events.amplitude.AmplitudeEventPublisher")
 
     repository = RepositoryFactory(
         name="the_repo",
@@ -431,6 +432,17 @@ def test_uploads_post_tokenless(db, mocker, mock_redis, private, branch, branch_
                 "uploader_type": "CLI",
             },
         )
+        amplitude_mock.return_value.publish.assert_called_with(
+            "Upload Sent",
+            {
+                "user_ownerid": commit.author.ownerid,
+                "ownerid": commit.repository.author.ownerid,
+                "repoid": commit.repository.repoid,
+                "commitid": commit.id,
+                "pullid": commit.pullid,
+                "upload_type": "Coverage report",
+            },
+        )
     else:
         assert response.status_code == 401
         assert response.json().get("detail") == "Not valid tokenless upload"
@@ -459,6 +471,7 @@ def test_uploads_post_token_required_auth_check(
         "upload.views.uploads.trigger_upload_task", return_value=True
     )
     analytics_service_mock = mocker.patch("upload.views.uploads.AnalyticsService")
+    amplitude_mock = mocker.path("shared.events.amplitude.AmplitudeEventPublisher")
 
     repository = RepositoryFactory(
         name="the_repo",
@@ -583,18 +596,31 @@ def test_uploads_post_token_required_auth_check(
                 "uploader_type": "CLI",
             },
         )
+        amplitude_mock.return_value.publish.assert_called_with(
+            "Upload Sent",
+            {
+                "user_ownerid": commit.author.ownerid,
+                "ownerid": commit.repository.author.ownerid,
+                "repoid": commit.repository.repoid,
+                "commitid": commit.id,
+                "pullid": commit.pullid,
+                "upload_type": "Coverage report",
+            },
+        )
     else:
         assert response.status_code == 401
         assert response.json().get("detail") == "Not valid tokenless upload"
 
 
+@patch("shared.events.amplitude.AmplitudeEventPublisher")
 @patch("upload.views.uploads.AnalyticsService")
 @patch("upload.helpers.jwt.decode")
 @patch("upload.helpers.PyJWKClient")
 def test_uploads_post_github_oidc_auth(
     mock_jwks_client,
     mock_jwt_decode,
     analytics_service_mock,
+    amplitude_mock,
     db,
     mocker,
     mock_redis,
@@ -717,6 +743,17 @@ def test_uploads_post_github_oidc_auth(
             "uploader_type": "CLI",
         },
     )
+    amplitude_mock.return_value.publish.assert_called_with(
+        "Upload Sent",
+        {
+            "user_ownerid": commit.author.ownerid,
+            "ownerid": commit.repository.author.ownerid,
+            "repoid": commit.repository.repoid,
+            "commitid": commit.id,
+            "pullid": commit.pullid,
+            "upload_type": "Coverage report",
+        },
+    )
 
 
 @override_settings(SHELTER_SHARED_SECRET="shelter-shared-secret")

upload/views/uploads.py

@@ -10,6 +10,7 @@
 from rest_framework.response import Response
 from rest_framework.views import APIView
 from shared.api_archive.archive import ArchiveService, MinioEndpoints
+from shared.events.amplitude import AmplitudeEventPublisher
 from shared.metrics import inc_counter
 from shared.upload.utils import UploaderType, insert_coverage_measurement
 
@@ -167,6 +168,17 @@ def send_analytics_data(
     AnalyticsService().account_uploaded_coverage_report(
         commit.repository.author.ownerid, analytics_upload_data
     )
+    AmplitudeEventPublisher().publish(
+        "Upload Sent",
+        {
+            "user_ownerid": commit.author.ownerid,
+            "ownerid": commit.repository.author.ownerid,
+            "repoid": commit.repository.repoid,
+            "commitid": commit.id,  # Not commit.commitid, we do not want a commit SHA here!
+            "pullid": commit.pullid,
+            "upload_type": "Coverage report",
+        },
+    )
 
 
 def get_token_for_analytics(commit: Commit, request: HttpRequest) -> str: