fix: Handle multiple invoices with charges edge case

Author: calvin-codecov

services/billing.py

@@ -173,9 +173,12 @@ def delete_subscription(self, owner: Owner):
             stripe.Subscription.cancel(owner.stripe_subscription_id)
 
             invoices_list = stripe.Invoice.list(subscription=owner.stripe_subscription_id, status="paid")
-            charge = invoices_list["data"][0]["charge"] if len(invoices_list["data"]) >= 1 and invoices_list["data"][0]["charge"] else None
-            if charge:
-                stripe.Refund.create(charge=charge)
+            created_refund = False
+            for invoice in invoices_list["data"]:
+                if invoice["charge"] is not None and invoice["amount_remaining"] == 0 and invoice["created"] < current_subscription_timestamp:
+                    stripe.Refund.create(invoice["charge"])
+                    created_refund = True
+            if created_refund == True:
                 stripe.Customer.modify(
                     owner.stripe_customer_id,
                     balance=0,

services/tests/samples/stripe_invoice.json

@@ -120,7 +120,7 @@
       "total_tax_amounts": [],
       "webhooks_delivered_at": 1489789437
     },
-      {
+    {
       "id": "in_19yTU92eZvKYlo2C7uDjvu69",
       "object": "invoice",
       "account_country": "US",

services/tests/test_billing.py

@@ -365,12 +365,10 @@ def test_delete_subscription_with_schedule_releases_schedule_and_cancels_subscri
     ):
         with open("./services/tests/samples/stripe_invoice.json") as f:
             stripe_invoice_response = json.load(f)
-        stripe_invoice_response["data"] = stripe_invoice_response["data"] * 2
         list_invoice_mock.return_value = stripe_invoice_response
         plan = PlanName.CODECOV_PRO_YEARLY.value
         stripe_subscription_id = "sub_1K77Y5GlVGuVgOrkJrLjRnne"
         stripe_schedule_id = "sub_sched_sch1K77Y5GlVGuVgOrkJrLjRnne"
-        charge = "ch_19yUQN2eZvKYlo2CQf7aWpSX"
         owner = OwnerFactory(
             stripe_subscription_id=stripe_subscription_id,
             plan=plan,
@@ -397,7 +395,7 @@ def test_delete_subscription_with_schedule_releases_schedule_and_cancels_subscri
         schedule_release_mock.assert_called_once_with(stripe_schedule_id)
         cancel_sub_mock.assert_called_once_with(stripe_subscription_id)
         list_invoice_mock.assert_called_once_with(subscription=stripe_subscription_id, status="paid")
-        create_refund_mock.assert_called_once_with(charge=charge)
+        self.assertEqual(create_refund_mock.call_count, 2)
         modify_customer_mock.assert_called_once_with(owner.stripe_customer_id, balance=0)
         modify_sub_mock.assert_not_called()
 
@@ -420,12 +418,10 @@ def test_delete_subscription_with_schedule_releases_schedule_and_cancels_subscri
     ):
         with open("./services/tests/samples/stripe_invoice.json") as f:
             stripe_invoice_response = json.load(f)
-        stripe_invoice_response["data"] = stripe_invoice_response["data"] * 2
         list_invoice_mock.return_value = stripe_invoice_response
         plan = PlanName.CODECOV_PRO_YEARLY.value
         stripe_subscription_id = "sub_1K77Y5GlVGuVgOrkJrLjRnne"
         stripe_schedule_id = "sub_sched_sch1K77Y5GlVGuVgOrkJrLjRnne"
-        charge = "ch_19yUQN2eZvKYlo2CQf7aWpSX"
         owner = OwnerFactory(
             stripe_subscription_id=stripe_subscription_id,
             plan=plan,
@@ -452,7 +448,7 @@ def test_delete_subscription_with_schedule_releases_schedule_and_cancels_subscri
         schedule_release_mock.assert_called_once_with(stripe_schedule_id)
         cancel_sub_mock.assert_called_once_with(stripe_subscription_id)
         list_invoice_mock.assert_called_once_with(subscription=stripe_subscription_id, status="paid")
-        create_refund_mock.assert_called_once_with(charge=charge)
+        self.assertEqual(create_refund_mock.call_count, 2)
         modify_customer_mock.assert_called_once_with(owner.stripe_customer_id, balance=0)
         modify_sub_mock.assert_not_called()