fix: address feedback

Author: joseph-sentry

graphql_api/tests/test_test_analytics.py

@@ -1138,7 +1138,7 @@ def test_test_suites_no_term(self) -> None:
         )
         res = self.fetch_test_analytics(
             repo.name,
-            """testSuites(term: "hello")""",
+            """testSuites""",
         )
         assert sorted(res["testSuites"]) == ["goodbye_world", "hello_world"]
 
@@ -1172,6 +1172,6 @@ def test_flags_no_term(self) -> None:
 
         res = self.fetch_test_analytics(
             repo.name,
-            """flags(term: "hello")""",
+            """flags""",
         )
         assert sorted(res["flags"]) == ["goodbye_world", "hello_world"]

utils/test_results.py

@@ -271,14 +271,12 @@ def compare(row: TestResultsRow) -> int:
         row_value = getattr(row, ordering)
         row_value_str = str(row_value)
         cursor_value_str = cursor.ordered_value
+        row_is_greater = row_value_str > cursor_value_str
+        row_is_less = row_value_str < cursor_value_str
         if descending:
-            return (row_value_str < cursor_value_str) - (
-                row_value_str > cursor_value_str
-            )
+            return row_is_less - row_is_greater
         else:
-            return (row_value_str > cursor_value_str) - (
-                row_value_str < cursor_value_str
-            )
+            return row_is_greater - row_is_less
 
     left, right = 0, len(rows) - 1
     while left <= right:

utils/tests/unit/test_search_base_query.py

@@ -53,7 +53,7 @@ def test_search_base_query_with_missing_cursor_low_name_high_failure_rate():
     assert res == rows[-1:]
 
 
-def test_search_base_query_with_missing_cursor_low_name_high_failure_rate_desc():
+def test_search_base_query_descending():
     # [(2, "0.2"), (1, "0.1"), (0, "0.0")]
     #             ^
     #             here's where the cursor is pointing at