add ruff rules for prints and fix

Author: ajay-sentry

codecov_auth/commands/owner/interactors/get_is_current_user_an_admin.py

@@ -50,5 +50,5 @@ def execute(self, owner, current_owner):
                         owner.add_admin(current_owner)
                     return isAdmin or (current_owner.ownerid in admins)
                 except Exception as error:
-                    print("Error Calling Admin Provider " + repr(error))
+                    print("Error Calling Admin Provider " + repr(error))  # noqa: T201
                     return False

core/management/commands/check_for_migration_conflicts.py

@@ -22,17 +22,16 @@ def handle(self, *args, **options):
                 for prefix, grouped_migrations in migrations_by_prefix.items():
                     if len(grouped_migrations) > 1:
                         conflicts_found = True
-                        print(
+                        print(  # noqa: T201
                             f"Conflict found in migrations for {app.name} with prefix {prefix}:"
                         )
                         for grouped_migration in grouped_migrations:
-                            print(grouped_migration)
-                        print()
+                            print(grouped_migration)  # noqa: T201
             # It's expected to not find migration folders for Django/3rd party apps
             except FileNotFoundError:
                 pass
 
         if conflicts_found:
             raise Exception("Found conflicts in migrations.")
         else:
-            print("No conflicts found!")
+            print("No conflicts found!")  # noqa: T201

core/management/commands/delete_rate_limit_keys.py

@@ -21,8 +21,8 @@ def handle(self, *args, **options):
             for key in redis.scan_iter(path):
                 # -1 means the key has no expiry
                 if redis.ttl(key) == -1:
-                    print(f"Deleting key: {key.decode('utf-8')}")
+                    print(f"Deleting key: {key.decode('utf-8')}")  # noqa: T201
                     redis.delete(key)
         except Exception as e:
-            print("Error occurred when deleting redis keys")
-            print(e)
+            print("Error occurred when deleting redis keys")  # noqa: T201
+            print(e)  # noqa: T201

core/management/commands/update_gitlab_webhooks.py

@@ -31,11 +31,8 @@ def handle(self, *args, **options):
         )
 
         for repo in repos:
-            print("repoid:", repo.pk)
-
             user = get_bot_user(repo)
             if user is None:
-                print("no bot user")
                 continue
 
             webhook_secret = str(uuid.uuid4())
@@ -63,7 +60,7 @@ def handle(self, *args, **options):
                 repo.webhook_secret = webhook_secret
                 repo.save()
             except TorngitClientError as e:
-                print("error making GitLab API call")
-                print(e)
+                print("error making GitLab API call")  # noqa: T201
+                print(e)  # noqa: T201
             except TorngitRefreshTokenFailedError:
-                print("refresh token failed")
+                print("refresh token failed")  # noqa: T201

graphql_api/tests/test_plan.py

@@ -210,7 +210,6 @@ def test_plan_user_count_for_enterprise_org(self, mocked_license):
                 }
                 """ % (enterprise_org.username)
         data = self.gql_request(query, owner=enterprise_org)
-        print(data, "look here 1")
         assert data["owner"]["plan"]["planUserCount"] == 5
         assert data["owner"]["plan"]["hasSeatsLeft"] == False
 

open_telemetry.py

@@ -141,15 +141,15 @@ def export(self, spans):
             logging.exception("failed to export all spans")
             return SpanExportResult.FAILURE
         except requests.HTTPError as e:
-            print(e)
-            logging.exception("HTTP server returned erroneous response")
+            logging.exception(
+                "HTTP server returned erroneous response", extra=dict(error=e)
+            )
             return SpanExportResult.FAILURE
         except requests.Timeout:
             logging.exception("request timed out")
             return SpanExportResult.FAILURE
         except Exception as e:
-            print(e)
-            logging.exception("request failed")
+            logging.exception("request failed", extra=dict(error=e))
             return SpanExportResult.FAILURE
 
         return SpanExportResult.SUCCESS

ruff.toml

@@ -46,6 +46,7 @@ select = [
     "PERF", # perflint - performance anti-pattern rules
     "PLC", # pylint - convention rules
     "PLE", # pylint - error rules
+    "T20", # flake8-print - print statements
     "W", # pycodestyle - warning rules
 ]
 ignore = ["F405", "F403", "E501", "E712", "C408"]