API Improvements: Fix typings for various files pt3

Author: JerrySentry

api/public/v2/component/views.py

@@ -1,6 +1,9 @@
+from typing import Any
+
 from drf_spectacular.types import OpenApiTypes
 from drf_spectacular.utils import OpenApiParameter, extend_schema
 from rest_framework import viewsets
+from rest_framework.request import Request
 from rest_framework.response import Response
 
 from api.public.v2.component.serializers import ComponentSerializer
@@ -34,7 +37,7 @@ class ComponentViewSet(viewsets.ViewSet, RepoPropertyMixin):
     permission_classes = [RepositoryArtifactPermissions]
 
     @extend_schema(summary="Component list")
-    def list(self, request, *args, **kwargs):
+    def list(self, request: Request, *args: Any, **kwargs: Any) -> Response:
         """
         Returns a list of components for the specified repository
         """

codecov_auth/commands/owner/interactors/get_uploads_number_per_user.py

@@ -1,3 +1,5 @@
+from typing import Optional
+
 from shared.plan.service import PlanService
 from shared.upload.utils import query_monthly_coverage_measurements
 
@@ -11,7 +13,7 @@
 
 class GetUploadsNumberPerUserInteractor(BaseInteractor):
     @sync_to_async
-    def execute(self, owner: Owner):
+    def execute(self, owner: Owner) -> Optional[int]:
         plan_service = PlanService(current_org=owner)
         monthly_limit = plan_service.monthly_uploads_limit
         if monthly_limit is not None:

core/signals.py

@@ -1,5 +1,5 @@
 import logging
-from typing import Any, Dict, List, Type
+from typing import Any, Dict, List, Type, cast
 
 from django.db.models.signals import post_save
 from django.dispatch import receiver
@@ -16,7 +16,7 @@ def update_repository(
     sender: Type[Repository], instance: Repository, **kwargs: Dict[str, Any]
 ) -> None:
     log.info(f"Signal triggered for repository {instance.repoid}")
-    created: bool = kwargs["created"]
+    created: bool = cast(bool, kwargs["created"])
     changes: Dict[str, Any] = instance.tracker.changed()
     tracked_fields: List[str] = ["name", "upload_token", "activated", "active"]
 

graphql_api/types/account/account.py

@@ -1,8 +1,10 @@
+from typing import Any, Coroutine, Optional
+
 from ariadne import ObjectType
 from graphql import GraphQLResolveInfo
 
 from codecov.db import sync_to_async
-from codecov_auth.models import Account, OktaSettings
+from codecov_auth.models import Account, OktaSettings, Owner
 from graphql_api.helpers.ariadne import ariadne_load_local_graphql
 from graphql_api.helpers.connection import (
     build_connection_graphql,
@@ -43,9 +45,9 @@ def resolve_activated_user_count(account: Account, info: GraphQLResolveInfo) ->
 def resolve_organizations(
     account: Account,
     info: GraphQLResolveInfo,
-    ordering_direction=OrderingDirection.ASC,
-    **kwargs,
-):
+    ordering_direction: Optional[OrderingDirection] = OrderingDirection.ASC,
+    **kwargs: Any,
+) -> Coroutine[Any, Any, Owner]:
     return queryset_to_connection(
         account.organizations,
         ordering=("username",),

services/profiling.py

@@ -16,7 +16,7 @@
 
 
 class CriticalFile:
-    def __init__(self, name):
+    def __init__(self, name: str) -> None:
         self.name = name
 
 
@@ -60,7 +60,7 @@ def summary_data(
             return None
 
     def _get_critical_files_from_yaml(
-        self, profiling_commit: ProfilingCommit = None
+        self, profiling_commit: Optional[ProfilingCommit] = None
     ) -> List[str]:
         """
         Get a list of files present in the commit report that are also marked as critical in the repo yaml (under profiling.critical_files_paths)
@@ -79,7 +79,12 @@ def _get_critical_files_from_yaml(
             "critical_files_paths"
         ):
             return []
-        commit_sha = self.commit_sha or profiling_commit.commit_sha
+
+        if profiling_commit is not None:
+            commit_sha = profiling_commit.commit_sha
+        else:
+            commit_sha = self.commit_sha
+
         commit = Commit.objects.get(commitid=commit_sha)
         report = report_service.build_report_from_commit(commit)
         if report is None:

services/report.py

@@ -29,13 +29,13 @@ def _sessions_with_specific_flags(
 
 
 def files_in_sessions(commit_report: Report, session_ids: list[int]) -> list[str]:
-    files, session_ids = [], set(session_ids)
+    files, session_ids_set = [], set(session_ids)
     for file in commit_report:
         found = False
         for line in file:
             if line:
                 for session in line.sessions:
-                    if session.id in session_ids:
+                    if session.id in session_ids_set:
                         found = True
                         break
             if found:

upload/throttles.py

@@ -3,8 +3,10 @@
 from django.conf import settings
 from django.core.exceptions import ObjectDoesNotExist
 from django.db.models import Q
+from django.http import HttpRequest
 from rest_framework.exceptions import ValidationError
 from rest_framework.throttling import BaseThrottle
+from rest_framework.views import APIView
 from shared.plan.service import PlanService
 from shared.reports.enums import UploadType
 from shared.upload.utils import query_monthly_coverage_measurements
@@ -19,7 +21,7 @@
 
 
 class UploadsPerCommitThrottle(BaseThrottle):
-    def allow_request(self, request, view):
+    def allow_request(self, request: HttpRequest, view: APIView) -> bool:
         try:
             repository = view.get_repo()
             commit = view.get_commit(repository)
@@ -44,7 +46,7 @@ def allow_request(self, request, view):
 
 
 class UploadsPerWindowThrottle(BaseThrottle):
-    def allow_request(self, request, view):
+    def allow_request(self, request: HttpRequest, view: APIView) -> bool:
         try:
             repository = view.get_repo()
             commit = view.get_commit(repository)

upload/tokenless/travis.py

@@ -1,5 +1,6 @@
 import logging
 from datetime import datetime, timedelta
+from typing import Any, Dict
 
 import requests
 from requests.exceptions import ConnectionError, HTTPError
@@ -12,7 +13,7 @@
 
 
 class TokenlessTravisHandler(BaseTokenlessUploadHandler):
-    def get_build(self):
+    def get_build(self) -> Dict[str, Any]:
         travis_dot_com = False
 
         try:
@@ -88,7 +89,7 @@ def get_build(self):
 
         return build.json()
 
-    def verify(self):
+    def verify(self) -> str:
         # find repo in travis.com
         job = self.get_build()
 

upload/views/upload_completion.py

@@ -1,5 +1,7 @@
 import logging
+from typing import Any, Callable, Dict
 
+from django.http import HttpRequest
 from rest_framework import status
 from rest_framework.generics import CreateAPIView
 from rest_framework.response import Response
@@ -33,10 +35,10 @@ class UploadCompletionView(CreateAPIView, GetterMixin):
         RepositoryLegacyTokenAuthentication,
     ]
 
-    def get_exception_handler(self):
+    def get_exception_handler(self) -> Callable[[Exception, Dict[str, Any]], Response]:
         return repo_auth_custom_exception_handler
 
-    def post(self, request, *args, **kwargs):
+    def post(self, request: HttpRequest, *args: Any, **kwargs: Any) -> Response:
         inc_counter(
             API_UPLOAD_COUNTER,
             labels=generate_upload_prometheus_metrics_labels(