fix: replace NaN values in aggregates with 0 (#981)

joseph-sentry · web-flow · commit 7d3c536a2276 · 2024-11-13T21:17:46.000Z
diff --git a/graphql_api/types/flake_aggregates/flake_aggregates.py b/graphql_api/types/flake_aggregates/flake_aggregates.py
@@ -42,7 +42,7 @@ def flake_aggregates_with_percentage(
     merged_results: pl.DataFrame = pl.concat([past_aggregates, curr_aggregates])
 
     merged_results = merged_results.with_columns(
-        pl.all().pct_change().name.suffix("_percent_change")
+        pl.all().pct_change().fill_nan(0).name.suffix("_percent_change")
     )
     aggregates = merged_results.row(1, named=True)
 
diff --git a/graphql_api/types/test_results_aggregates/test_results_aggregates.py b/graphql_api/types/test_results_aggregates/test_results_aggregates.py
@@ -71,7 +71,7 @@ def test_results_aggregates_with_percentage(
     # with_columns upserts the new columns, so if the name already exists it get overwritten
     # otherwise it's just added
     merged_results = merged_results.with_columns(
-        pl.all().pct_change().name.suffix("_percent_change")
+        pl.all().pct_change().fill_nan(0).name.suffix("_percent_change")
     )
     aggregates = merged_results.row(1, named=True)
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ def flake_aggregates_with_percentage(`
`42`	`42`	`merged_results: pl.DataFrame = pl.concat([past_aggregates, curr_aggregates])`
`43`	`43`
`44`	`44`	`merged_results = merged_results.with_columns(`
`45`		`- pl.all().pct_change().name.suffix("_percent_change")`
	`45`	`+ pl.all().pct_change().fill_nan(0).name.suffix("_percent_change")`
`46`	`46`	`)`
`47`	`47`	`aggregates = merged_results.row(1, named=True)`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ def test_results_aggregates_with_percentage(`
`71`	`71`	`# with_columns upserts the new columns, so if the name already exists it get overwritten`
`72`	`72`	`# otherwise it's just added`
`73`	`73`	`merged_results = merged_results.with_columns(`
`74`		`- pl.all().pct_change().name.suffix("_percent_change")`
	`74`	`+ pl.all().pct_change().fill_nan(0).name.suffix("_percent_change")`
`75`	`75`	`)`
`76`	`76`	`aggregates = merged_results.row(1, named=True)`
`77`	`77`