fix: pass repoid to get_appropriate_storage_service (#1209)

joseph-sentry · web-flow · commit 8d9cd04d24a6 · 2025-03-12T20:36:00.000Z
diff --git a/graphql_api/dataloader/bundle_analysis.py b/graphql_api/dataloader/bundle_analysis.py
@@ -30,7 +30,7 @@ def load_bundle_analysis_comparison(
         return MissingBaseReport()
 
     loader = BundleAnalysisReportLoader(
-        storage_service=get_appropriate_storage_service(),
+        storage_service=get_appropriate_storage_service(head_commit.repository.repoid),
         repo_key=ArchiveService.get_archive_hash(head_commit.repository),
     )
 
@@ -57,7 +57,7 @@ def load_bundle_analysis_report(
         return MissingHeadReport()
 
     loader = BundleAnalysisReportLoader(
-        storage_service=get_appropriate_storage_service(),
+        storage_service=get_appropriate_storage_service(commit.repository.repoid),
         repo_key=ArchiveService.get_archive_hash(commit.repository),
     )
     report = loader.load(report.external_id)
diff --git a/services/bundle_analysis.py b/services/bundle_analysis.py
@@ -38,7 +38,7 @@
 def load_report(
     commit: Commit, report_code: Optional[str] = None
 ) -> Optional[SharedBundleAnalysisReport]:
-    storage = get_appropriate_storage_service()
+    storage = get_appropriate_storage_service(commit.repository.repoid)
 
     commit_report = commit.reports.filter(
         report_type=CommitReport.ReportType.BUNDLE_ANALYSIS,
diff --git a/utils/test_results.py b/utils/test_results.py
@@ -55,7 +55,7 @@ def get_results(
 
     if result is None:
         # try storage
-        storage_service = get_appropriate_storage_service()
+        storage_service = get_appropriate_storage_service(repoid)
         key = storage_key(repoid, branch, interval_start, interval_end)
         try:
             result = storage_service.read_file(

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ def load_bundle_analysis_comparison(`
`30`	`30`	`return MissingBaseReport()`
`31`	`31`
`32`	`32`	`loader = BundleAnalysisReportLoader(`
`33`		`- storage_service=get_appropriate_storage_service(),`
	`33`	`+ storage_service=get_appropriate_storage_service(head_commit.repository.repoid),`
`34`	`34`	`repo_key=ArchiveService.get_archive_hash(head_commit.repository),`
`35`	`35`	`)`
`36`	`36`
`@@ -57,7 +57,7 @@ def load_bundle_analysis_report(`
`57`	`57`	`return MissingHeadReport()`
`58`	`58`
`59`	`59`	`loader = BundleAnalysisReportLoader(`
`60`		`- storage_service=get_appropriate_storage_service(),`
	`60`	`+ storage_service=get_appropriate_storage_service(commit.repository.repoid),`
`61`	`61`	`repo_key=ArchiveService.get_archive_hash(commit.repository),`
`62`	`62`	`)`
`63`	`63`	`report = loader.load(report.external_id)`