update

Author: rohitvinnakota-codecov

graphql_api/types/impacted_file/impacted_file.py

@@ -98,8 +98,12 @@ def resolve_segments(
         # segments with no diff changes and at least 1 unintended change
         segments = [segment for segment in segments if segment.has_unintended_changes]
     elif filters.get("has_unintended_changes") is False:
-        file_comparison.reset_lines_without_unintended_changes()
-        segments = file_comparison.segments
+        filtered_segments = []
+        for segment in segments:
+            if segment.has_diff_changes:
+                segment.reset_lines_without_unintended_changes()
+                filtered_segments.append(segment)
+        segments = filtered_segments
 
     return SegmentComparisons(results=segments)
 

services/comparison.py

@@ -481,14 +481,17 @@ def has_unintended_changes(self):
                 return True
         return False
 
+    
     def reset_lines_without_unintended_changes(self):
         if self.lines is None:
             return
-        filtered = [l for l in self.lines if not l.get('unintended_change', False)]
-        if hasattr(self, '_calculated_changes_and_lines'):
-            summary, _ = self._calculated_changes_and_lines
-            self._calculated_changes_and_lines = (summary, filtered)
-        self.lines = filtered
+        new_lines = []
+        for line in self.lines:
+            head_coverage = line.coverage["base"]
+            base_coverage = line.coverage["head"]
+            if not (line.added or line.removed) and (base_coverage != head_coverage):
+                new_lines.append(line)
+        self.lines = new_lines
 
 
 class FileComparison: