add other var

Author: adrian-codecov

upload/tests/views/test_bundle_analysis.py

@@ -104,6 +104,7 @@ def test_upload_bundle_analysis_success(db, client, mocker, mock_redis):
 
 
 @pytest.mark.django_db(databases={"default", "timeseries"})
+@override_settings(SHELTER_SHARED_SECRET="shelter-shared-secret")
 def test_upload_bundle_analysis_success_shelter(db, client, mocker, mock_redis):
     upload = mocker.patch.object(TaskService, "upload")
     mock_sentry_metrics = mocker.patch(
@@ -131,6 +132,7 @@ def test_upload_bundle_analysis_success_shelter(db, client, mocker, mock_redis):
             "service": "test-service",
             "compareSha": "6fd5b89357fc8cdf34d6197549ac7c6d7e5aaaaa",
             "storage_path": "shelter/test/path.txt",
+            "upload_external_id": "test-47078f85-2cee-4511-b38d-183c334ef43b",
         },
         format="json",
         headers={"User-Agent": "codecov-cli/0.4.7"},

upload/views/bundle_analysis.py

@@ -50,6 +50,7 @@ class UploadSerializer(serializers.Serializer):
     compareSha = serializers.CharField(required=False, allow_null=True)
     git_service = serializers.CharField(required=False, allow_null=True)
     storage_path = serializers.CharField(required=False, allow_null=True)
+    upload_external_id = serializers.CharField(required=False, allow_null=True)
 
 
 class BundleAnalysisView(APIView, ShelterMixin):
@@ -118,8 +119,9 @@ def post(self, request: HttpRequest) -> Response:
         )
 
         storage_path = data.get("storage_path", None)
+        upload_external_id = data.get("upload_external_id", None)
         url = None
-        if storage_path is None or not self.is_shelter_request():
+        if not self.is_shelter_request():
             upload_external_id = str(uuid.uuid4())
             storage_path = StoragePaths.upload.path(upload_key=upload_external_id)
             archive_service = ArchiveService(repo)