Mkerge branch 'main' of github.com:codecov/codecov-api into 2591-ba-endpoint-expects-storage-path

Author: adrian-codecov

graphql_api/tests/test_test_result.py

@@ -31,13 +31,15 @@ def setUp(self):
             date=date.today() - timedelta(days=2),
             avg_duration_seconds=0.6,
             latest_run=datetime.now() - timedelta(days=2),
+            flaky_fail_count=0,
         )
         _ = DailyTestRollupFactory(
             test=self.test,
             commits_where_fail=["123", "456"],
             date=datetime.now() - timedelta(days=1),
             avg_duration_seconds=2,
             latest_run=datetime.now() - timedelta(days=1),
+            flaky_fail_count=1,
         )
         _ = DailyTestRollupFactory(
             test=self.test,
@@ -46,6 +48,7 @@ def setUp(self):
             last_duration_seconds=5.0,
             avg_duration_seconds=3,
             latest_run=datetime.now(),
+            flaky_fail_count=1,
         )
 
     def test_fetch_test_result_name(self) -> None:
@@ -354,3 +357,34 @@ def test_fetch_test_result_total_pass_count(self) -> None:
             ]["totalPassCount"]
             == 3
         )
+
+    def test_fetch_test_result_total_flaky_fail_count(self) -> None:
+        query = """
+            query {
+               owner(username: "%s") {
+                    repository(name: "%s") {
+                        ... on Repository {
+                            testAnalytics {
+                                testResults {
+                                    edges {
+                                        node {
+                                            totalFlakyFailCount
+                                        }
+                                    }
+                                }
+                            }
+                        }
+                    }
+                 }
+            }
+        """ % (self.owner.username, self.repository.name)
+
+        result = self.gql_request(query, owner=self.owner)
+
+        assert "errors" not in result
+        assert (
+            result["owner"]["repository"]["testAnalytics"]["testResults"]["edges"][0][
+                "node"
+            ]["totalFlakyFailCount"]
+            == 2
+        )

graphql_api/tests/test_test_results_headers.py

@@ -137,3 +137,30 @@ def test_fetch_test_result_skipped_tests(self) -> None:
             ]
             == 29
         )
+
+    def test_fetch_test_result_slow_tests(self) -> None:
+        query = """
+            query {
+            owner(username: "%s") {
+                    repository(name: "%s") {
+                        ... on Repository {
+                            testAnalytics {
+                                testResultsAggregates {
+                                    totalSlowTests
+                                }
+                            }
+                        }
+                    }
+                }
+            }
+        """ % (self.owner.username, self.repository.name)
+
+        result = self.gql_request(query, owner=self.owner)
+
+        assert "errors" not in result
+        assert (
+            result["owner"]["repository"]["testAnalytics"]["testResultsAggregates"][
+                "totalSlowTests"
+            ]
+            == 1
+        )

graphql_api/types/test_results/test_results.graphql

@@ -7,6 +7,7 @@ type TestResult {
   avgDuration: Float!
   lastDuration: Float!
   totalFailCount: Int!
+  totalFlakyFailCount: Int!
   totalSkipCount: Int!
   totalPassCount: Int!
 }

graphql_api/types/test_results/test_results.py

@@ -14,6 +14,7 @@ class TestDict(TypedDict):
     last_duration: float
     flake_rate: float
     total_fail_count: int
+    total_flaky_fail_count: int
     total_skip_count: int
     total_pass_count: int
     computed_name: str | None
@@ -62,6 +63,11 @@ def resolve_total_fail_count(test: TestDict, _: GraphQLResolveInfo) -> int:
     return test["total_fail_count"]
 
 
+@test_result_bindable.field("totalFlakyFailCount")
+def resolve_total_flaky_fail_count(test: TestDict, _: GraphQLResolveInfo) -> int:
+    return test["total_flaky_fail_count"]
+
+
 @test_result_bindable.field("totalSkipCount")
 def resolve_total_skip_count(test: TestDict, _: GraphQLResolveInfo) -> int:
     return test["total_skip_count"]

graphql_api/types/test_results_aggregates/test_results_aggregates.py

@@ -11,6 +11,8 @@ class TestResultsAggregates(TypedDict):
     total_duration_percent_change: float | None
     slowest_tests_duration: float
     slowest_tests_duration_percent_change: float | None
+    total_slow_tests: int
+    total_slow_tests_percent_change: float | None
     fails: int
     fails_percent_change: float | None
     skips: int
@@ -43,6 +45,18 @@ def resolve_slowest_tests_duration_percent_change(
     return obj.get("slowest_tests_duration_percent_change")
 
 
+@test_results_aggregates_bindable.field("totalSlowTests")
+def resolve_total_slow_tests(obj: TestResultsAggregates, _: GraphQLResolveInfo) -> int:
+    return obj["total_slow_tests"]
+
+
+@test_results_aggregates_bindable.field("totalSlowTestsPercentChange")
+def resolve_total_slow_tests_percent_change(
+    obj: TestResultsAggregates, _: GraphQLResolveInfo
+) -> float | None:
+    return obj.get("total_slow_tests_percent_change")
+
+
 @test_results_aggregates_bindable.field("totalFails")
 def resolve_total_fails(obj: TestResultsAggregates, _: GraphQLResolveInfo) -> int:
     return obj["fails"]

utils/test_results.py

@@ -33,7 +33,7 @@
 def slow_test_threshold(total_tests: int) -> int:
     percentile = (100 - SLOW_TEST_PERCENTILE) / 100
     slow_tests_to_return = floor(percentile * total_tests)
-    return max(slow_tests_to_return, 1)
+    return min(max(slow_tests_to_return, 1), 100)
 
 
 class ArrayLength(Func):

utils/tests/unit/test_slow_test_threshold.py

@@ -0,0 +1,23 @@
+import pytest
+
+from utils.test_results import slow_test_threshold
+
+
+@pytest.mark.parametrize(
+    "total_tests, expected_threshold",
+    [
+        (0, 1),
+        (1, 1),
+        (10, 1),
+        (100, 5),
+        (1000, 50),
+        (10000, 100),
+        (1000000, 100),
+        (20, 1),
+        (50, 2),
+        (200, 10),
+        (2000, 100),
+    ],
+)
+def test_slow_test_threshold(total_tests, expected_threshold):
+    assert slow_test_threshold(total_tests) == expected_threshold