chore: Cleanup unused graphql fields - coverageAnalytics (#843)

Author: suejung-sentry

graphql_api/tests/test_repository.py

@@ -52,11 +52,6 @@
 
 default_fields = """
     name
-    coverage
-    coverageSha
-    hits
-    misses
-    lines
     active
     private
     updatedAt
@@ -116,16 +111,22 @@ def test_when_repository_has_no_coverage(self):
             repository_id=repo.repoid, token_type="profiling"
         ).key
         graphToken = repo.image_token
-        assert self.fetch_repository(repo.name) == {
+        assert self.fetch_repository(
+            repo.name,
+            default_fields
+            + "coverageAnalytics { percentCovered commitSha hits misses lines },",
+        ) == {
             "__typename": "Repository",
             "name": "a",
             "active": True,
             "private": True,
-            "coverage": None,
-            "coverageSha": None,
-            "hits": None,
-            "misses": None,
-            "lines": None,
+            "coverageAnalytics": {
+                "percentCovered": None,
+                "commitSha": None,
+                "hits": None,
+                "misses": None,
+                "lines": None,
+            },
             "latestCommitAt": None,
             "oldestCommitAt": None,
             "updatedAt": "2021-01-01T00:00:00+00:00",
@@ -174,18 +175,24 @@ def test_when_repository_has_coverage(self):
             repository_id=repo.repoid, token_type="profiling"
         ).key
         graphToken = repo.image_token
-        assert self.fetch_repository(repo.name) == {
+        assert self.fetch_repository(
+            repo.name,
+            default_fields
+            + "coverageAnalytics { percentCovered commitSha hits misses lines },",
+        ) == {
             "__typename": "Repository",
             "name": "b",
             "active": True,
             "latestCommitAt": None,
             "oldestCommitAt": "2020-12-31T23:00:00",  # hour ago
             "private": True,
-            "coverage": 75,
-            "coverageSha": coverage_commit.commitid,
-            "hits": 30,
-            "misses": 10,
-            "lines": 40,
+            "coverageAnalytics": {
+                "percentCovered": 75,
+                "commitSha": coverage_commit.commitid,
+                "hits": 30,
+                "misses": 10,
+                "lines": 40,
+            },
             "updatedAt": "2021-01-01T00:00:00+00:00",
             "uploadToken": repo.upload_token,
             "defaultBranch": "master",

graphql_api/tests/test_repository_measurements.py

@@ -7,16 +7,6 @@ type Repository {
   active: Boolean!
   activated: Boolean!
   private: Boolean!
-  # coverage to be removed with #2282
-  coverage: Float
-  # coverageSha to be removed with #2282
-  coverageSha: String
-  # hits to be removed with #2282
-  hits: Int
-  # misses to be removed with #2282
-  misses: Int
-  # lines to be removed with #2282
-  lines: Int
   oldestCommitAt: DateTime
   latestCommitAt: DateTime
   updatedAt: DateTime
@@ -67,13 +57,6 @@ type Repository {
   componentsMeasurementsActive: Boolean!
   componentsMeasurementsBackfilled: Boolean!
   componentsCount: Int!
-  # (coverage) measurements to be removed with #2282
-  measurements(
-    interval: MeasurementInterval!
-    after: DateTime
-    before: DateTime
-    branch: String
-  ): [Measurement!]!
   repositoryConfig: RepositoryConfig
   staticAnalysisToken: String
   isATSConfigured: Boolean

graphql_api/types/repository/repository.graphql

@@ -1,6 +1,6 @@
 import logging
 from datetime import datetime
-from typing import Iterable, List, Mapping, Optional
+from typing import List, Mapping, Optional
 
 import shared.rate_limits as rate_limits
 import yaml
@@ -10,7 +10,6 @@
 from graphql.type.definition import GraphQLResolveInfo
 from shared.yaml import UserYaml
 
-import timeseries.helpers as timeseries_helpers
 from codecov.db import sync_to_async
 from codecov_auth.models import SERVICE_GITHUB, SERVICE_GITHUB_ENTERPRISE
 from core.models import Branch, Repository
@@ -35,8 +34,7 @@
 from services.components import ComponentMeasurements
 from services.profiling import CriticalFile, ProfilingSummary
 from services.redis_configuration import get_redis_connection
-from timeseries.helpers import fill_sparse_measurements
-from timeseries.models import Dataset, Interval, MeasurementName, MeasurementSummary
+from timeseries.models import Dataset, Interval, MeasurementName
 from utils.test_results import aggregate_test_results
 
 log = logging.getLogger(__name__)
@@ -62,31 +60,6 @@ def resolve_oldest_commit_at(
         return None
 
 
-@repository_bindable.field("coverage")
-def resolve_coverage(repository: Repository, info: GraphQLResolveInfo):
-    return repository.recent_coverage
-
-
-@repository_bindable.field("coverageSha")
-def resolve_coverage_sha(repository: Repository, info: GraphQLResolveInfo):
-    return repository.coverage_sha
-
-
-@repository_bindable.field("hits")
-def resolve_hits(repository: Repository, info: GraphQLResolveInfo) -> Optional[int]:
-    return repository.hits
-
-
-@repository_bindable.field("misses")
-def resolve_misses(repository: Repository, info: GraphQLResolveInfo) -> Optional[int]:
-    return repository.misses
-
-
-@repository_bindable.field("lines")
-def resolve_lines(repository: Repository, info: GraphQLResolveInfo) -> Optional[int]:
-    return repository.lines
-
-
 @repository_bindable.field("branch")
 def resolve_branch(
     repository: Repository, info: GraphQLResolveInfo, name: str
@@ -374,30 +347,6 @@ def resolve_is_ats_configured(repository: Repository, info: GraphQLResolveInfo)
     return individual_flags.get("carryforward_mode") == "labels"
 
 
-@repository_bindable.field("measurements")
-@sync_to_async
-def resolve_measurements(
-    repository: Repository,
-    info: GraphQLResolveInfo,
-    interval: Interval,
-    before: Optional[datetime] = None,
-    after: Optional[datetime] = None,
-    branch: Optional[str] = None,
-) -> Iterable[MeasurementSummary]:
-    return fill_sparse_measurements(
-        timeseries_helpers.repository_coverage_measurements_with_fallback(
-            repository,
-            interval,
-            start_date=after,
-            end_date=before,
-            branch=branch,
-        ),
-        interval,
-        start_date=after,
-        end_date=before,
-    )
-
-
 @repository_bindable.field("repositoryConfig")
 def resolve_repository_config(repository: Repository, info: GraphQLResolveInfo):
     return repository