Use get_flag_names more consistently

Swatinem · Swatinem · commit a73dee56365a · 2025-03-10T13:38:01.000+01:00
We are using the `.flags` property in a lot of places where we only ever wanted the `.keys()`.
So lets use `get_flag_names` instead, which does exactly that.
diff --git a/api/internal/tests/views/test_coverage_viewset.py b/api/internal/tests/views/test_coverage_viewset.py
@@ -10,7 +10,8 @@
     OwnerFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from services.components import Component
diff --git a/api/public/v2/report/views.py b/api/public/v2/report/views.py
@@ -112,7 +112,7 @@ def filter_report(
                 # empty report since the path is not part of the component
                 return Report()
 
-            component_flags = component.get_matching_flags(report.flags.keys())
+            component_flags = component.get_matching_flags(report.get_flag_names())
             if flag and len(component.flag_regexes) > 0 and flag not in component_flags:
                 # empty report since the flag is not part of the component
                 return Report()
diff --git a/api/public/v2/tests/test_api_compare_viewset.py b/api/public/v2/tests/test_api_compare_viewset.py
@@ -12,8 +12,8 @@
     RepositoryFactory,
 )
 from shared.reports.api_report_service import SerializableReport
-from shared.reports.resources import Report, ReportFile, ReportLine
-from shared.reports.types import ReportTotals
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine, ReportTotals
 from shared.utils.merge import LineType
 from shared.utils.sessions import Session
 
diff --git a/api/public/v2/tests/test_api_component_viewset.py b/api/public/v2/tests/test_api_component_viewset.py
@@ -7,7 +7,8 @@
     OwnerFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from services.components import Component
diff --git a/api/public/v2/tests/test_file_report_viewset.py b/api/public/v2/tests/test_file_report_viewset.py
@@ -9,7 +9,8 @@
     OwnerFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from core.models import Branch
diff --git a/api/public/v2/tests/test_flag_viewset.py b/api/public/v2/tests/test_flag_viewset.py
@@ -7,7 +7,8 @@
     OwnerFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from reports.tests.factories import RepositoryFlagFactory
diff --git a/api/public/v2/tests/test_report_tree.py b/api/public/v2/tests/test_report_tree.py
@@ -8,7 +8,8 @@
     OwnerFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from utils.test_utils import APIClient
diff --git a/api/public/v2/tests/test_report_viewset.py b/api/public/v2/tests/test_report_viewset.py
@@ -13,7 +13,8 @@
     CommitFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from services.components import Component
diff --git a/api/public/v2/tests/test_totals_viewset.py b/api/public/v2/tests/test_totals_viewset.py
@@ -10,7 +10,8 @@
     OwnerFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from services.components import Component
diff --git a/compare/commands/compare/interactors/fetch_impacted_files.py b/compare/commands/compare/interactors/fetch_impacted_files.py
@@ -41,6 +41,7 @@ def _apply_filters(
         components_flags = []
 
         head_commit_report = comparison.head_report_without_applied_diff
+        report_flags = head_commit_report.get_flag_names()
         if components_filter:
             all_components = components.commit_components(
                 comparison.head_commit, comparison.user
@@ -50,9 +51,7 @@ def _apply_filters(
             )
             for component in filtered_components:
                 components_paths.extend(component.paths)
-                components_flags.extend(
-                    component.get_matching_flags(head_commit_report.flags.keys())
-                )
+                components_flags.extend(component.get_matching_flags(report_flags))
 
         # Flags & Components intersection
         if components_flags:
@@ -62,7 +61,7 @@ def _apply_filters(
                 flags_filter = components_flags
 
         if flags_filter:
-            if set(flags_filter) & set(head_commit_report.flags):
+            if set(flags_filter) & set(report_flags):
                 files = files_belonging_to_flags(
                     commit_report=head_commit_report, flags=flags_filter
                 )
diff --git a/compare/commands/compare/interactors/tests/test_fetch_impacted_files.py b/compare/commands/compare/interactors/tests/test_fetch_impacted_files.py
@@ -8,7 +8,8 @@
     PullFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from compare.commands.compare.interactors.fetch_impacted_files import (
diff --git a/conftest.py b/conftest.py
@@ -4,7 +4,8 @@
 import pytest
 import vcr
 from django.conf import settings
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 # we need to enable this in the test environment since we're often creating
diff --git a/graphql_api/tests/test_components.py b/graphql_api/tests/test_components.py
@@ -10,7 +10,8 @@
     PullFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from compare.models import CommitComparison
diff --git a/graphql_api/tests/test_impacted_file.py b/graphql_api/tests/test_impacted_file.py
@@ -10,7 +10,8 @@
     PullFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.torngit.exceptions import (
     TorngitClientGeneralError,
     TorngitObjectNotFoundError,
diff --git a/graphql_api/tests/test_path_content.py b/graphql_api/tests/test_path_content.py
@@ -2,8 +2,8 @@
 
 from django.test import TransactionTestCase
 from shared.django_apps.core.tests.factories import CommitFactory
-from shared.reports.resources import Report, ReportFile, ReportLine
-from shared.reports.types import ReportTotals
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine, ReportTotals
 from shared.utils.sessions import Session
 
 from services.path import Dir, File
diff --git a/graphql_api/types/commit/commit.py b/graphql_api/types/commit/commit.py
@@ -160,6 +160,8 @@ def get_sorted_path_contents(
     component_paths = []
     component_flags = []
 
+    report_flags = report.get_flag_names()
+
     if component_filter:
         all_components = components_service.commit_components(commit, current_owner)
         filtered_components = components_service.filter_components_by_name_or_id(
@@ -173,18 +175,16 @@ def get_sorted_path_contents(
 
         for component in filtered_components:
             component_paths.extend(component.paths)
-            if report.flags:
-                component_flags.extend(
-                    component.get_matching_flags(report.flags.keys())
-                )
+            if report_flags:
+                component_flags.extend(component.get_matching_flags(report_flags))
 
     if component_flags:
         if flags_filter:
             flags_filter = list(set(flags_filter) & set(component_flags))
         else:
             flags_filter = component_flags
 
-    if flags_filter and not report.flags:
+    if flags_filter and not report_flags:
         return UnknownFlags(f"No coverage with chosen flags: {flags_filter}")
 
     report_paths = ReportPaths(
@@ -325,8 +325,8 @@ def resolve_coverage_totals(
 @sentry_sdk.trace
 @commit_coverage_analytics_bindable.field("flagNames")
 @sync_to_async
-def resolve_coverage_flags(commit: Commit, info: GraphQLResolveInfo) -> List[str]:
-    return commit.full_report.flags.keys()
+def resolve_coverage_flags(commit: Commit, info: GraphQLResolveInfo) -> list[str]:
+    return commit.full_report.get_flag_names()
 
 
 @sentry_sdk.trace
diff --git a/graphql_api/types/comparison/comparison.py b/graphql_api/types/comparison/comparison.py
@@ -45,7 +45,9 @@ def resolve_impacted_files(
 
     if filters and comparison:
         flags = filters.get("flags", [])
-        if flags and set(flags).isdisjoint(set(comparison.head_report.flags)):
+        if flags and set(flags).isdisjoint(
+            set(comparison.head_report.get_flag_names())
+        ):
             return UnknownFlags()
 
     return {
diff --git a/pyproject.toml b/pyproject.toml
@@ -78,4 +78,4 @@ dev-dependencies = [
 ]
 
 [tool.uv.sources]
-shared = { git = "https://github.com/codecov/shared", rev = "4755e7f77efc711c6ca34c2fb284edce71836402" }
+shared = { git = "https://github.com/codecov/shared", rev = "079d368c402758bc7ccb47572425237a9ebd9f9b" }
diff --git a/services/components.py b/services/components.py
@@ -33,7 +33,7 @@ def component_filtered_report(
     """
     flags, paths = [], []
     for component in components:
-        flags.extend(component.get_matching_flags(report.flags.keys()))
+        flags.extend(component.get_matching_flags(report.get_flag_names()))
         paths.extend(component.paths)
     filtered_report = report.filter(flags=flags, paths=paths)
     return filtered_report
diff --git a/services/tests/test_components.py b/services/tests/test_components.py
@@ -8,7 +8,8 @@
     OwnerFactory,
     RepositoryFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 from shared.yaml.user_yaml import UserYaml
 
diff --git a/services/tests/test_path.py b/services/tests/test_path.py
@@ -5,8 +5,8 @@
 from django.test import TestCase
 from shared.django_apps.core.tests.factories import CommitFactory, OwnerFactory
 from shared.reports.api_report_service import SerializableReport
-from shared.reports.resources import Report, ReportFile, ReportLine
-from shared.reports.types import ReportTotals
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine, ReportTotals
 from shared.torngit.exceptions import TorngitClientGeneralError
 from shared.utils.sessions import Session
 
diff --git a/services/tests/test_report.py b/services/tests/test_report.py
@@ -10,7 +10,8 @@
     build_report,
     build_report_from_commit,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.storage.exceptions import FileNotInStorageError
 from shared.utils.sessions import Session
 
diff --git a/timeseries/tests/test_helpers.py b/timeseries/tests/test_helpers.py
@@ -15,7 +15,8 @@
     DatasetFactory,
     MeasurementFactory,
 )
-from shared.reports.resources import Report, ReportFile, ReportLine
+from shared.reports.resources import Report, ReportFile
+from shared.reports.types import ReportLine
 from shared.utils.sessions import Session
 
 from timeseries.helpers import (
diff --git a/uv.lock b/uv.lock

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,8 @@`
`10`	`10`	`OwnerFactory,`
`11`	`11`	`RepositoryFactory,`
`12`	`12`	`)`
`13`		`-from shared.reports.resources import Report, ReportFile, ReportLine`
	`13`	`+from shared.reports.resources import Report, ReportFile`
	`14`	`+from shared.reports.types import ReportLine`
`14`	`15`	`from shared.utils.sessions import Session`
`15`	`16`
`16`	`17`	`from services.components import Component`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,8 @@`
`7`	`7`	`OwnerFactory,`
`8`	`8`	`RepositoryFactory,`
`9`	`9`	`)`
`10`		`-from shared.reports.resources import Report, ReportFile, ReportLine`
	`10`	`+from shared.reports.resources import Report, ReportFile`
	`11`	`+from shared.reports.types import ReportLine`
`11`	`12`	`from shared.utils.sessions import Session`
`12`	`13`
`13`	`14`	`from services.components import Component`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,8 @@`
`9`	`9`	`OwnerFactory,`
`10`	`10`	`RepositoryFactory,`
`11`	`11`	`)`
`12`		`-from shared.reports.resources import Report, ReportFile, ReportLine`
	`12`	`+from shared.reports.resources import Report, ReportFile`
	`13`	`+from shared.reports.types import ReportLine`
`13`	`14`	`from shared.utils.sessions import Session`
`14`	`15`
`15`	`16`	`from core.models import Branch`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,8 @@`
`8`	`8`	`OwnerFactory,`
`9`	`9`	`RepositoryFactory,`
`10`	`10`	`)`
`11`		`-from shared.reports.resources import Report, ReportFile, ReportLine`
	`11`	`+from shared.reports.resources import Report, ReportFile`
	`12`	`+from shared.reports.types import ReportLine`
`12`	`13`	`from shared.utils.sessions import Session`
`13`	`14`
`14`	`15`	`from utils.test_utils import APIClient`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,8 @@`
`13`	`13`	`CommitFactory,`
`14`	`14`	`RepositoryFactory,`
`15`	`15`	`)`
`16`		`-from shared.reports.resources import Report, ReportFile, ReportLine`
	`16`	`+from shared.reports.resources import Report, ReportFile`
	`17`	`+from shared.reports.types import ReportLine`
`17`	`18`	`from shared.utils.sessions import Session`
`18`	`19`
`19`	`20`	`from services.components import Component`