bundle analysis: prometheus, remove try/catch (#908)

Author: JerrySentry

upload/views/bundle_analysis.py

@@ -35,7 +35,7 @@
 
 BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER = Counter(
     "bundle_analysis_upload_views_runs",
-    "Number of times a raw report processor was run and with what result",
+    "Number of times a BA upload was run and with what result",
     [
         "agent",
         "version",
@@ -80,21 +80,14 @@ def get_exception_handler(self) -> Callable:
         return repo_auth_custom_exception_handler
 
     def post(self, request: HttpRequest) -> Response:
-        try:
-            labels = generate_upload_sentry_metrics_tags(
-                action="bundle_analysis",
-                endpoint="bundle_analysis",
-                request=self.request,
-                is_shelter_request=self.is_shelter_request(),
-                position="start",
-            )
-            BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()
-        except Exception:
-            log.warn(
-                "Failed to BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER",
-                exc_info=True,
-                extra=labels,
-            )
+        labels = generate_upload_sentry_metrics_tags(
+            action="bundle_analysis",
+            endpoint="bundle_analysis",
+            request=self.request,
+            is_shelter_request=self.is_shelter_request(),
+            position="start",
+        )
+        BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()
 
         serializer = UploadSerializer(data=request.data)
         if not serializer.is_valid():
@@ -174,21 +167,14 @@ def post(self, request: HttpRequest) -> Response:
                 task_arguments=task_arguments,
             ),
         )
-        try:
-            labels = generate_upload_sentry_metrics_tags(
-                action="bundle_analysis",
-                endpoint="bundle_analysis",
-                request=self.request,
-                is_shelter_request=self.is_shelter_request(),
-                position="end",
-            )
-            BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()
-        except Exception:
-            log.warn(
-                "Failed to BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER",
-                exc_info=True,
-                extra=labels,
-            )
+        labels = generate_upload_sentry_metrics_tags(
+            action="bundle_analysis",
+            endpoint="bundle_analysis",
+            request=self.request,
+            is_shelter_request=self.is_shelter_request(),
+            position="end",
+        )
+        BUNDLE_ANALYSIS_UPLOAD_VIEWS_COUNTER.labels(**labels).inc()
 
         dispatch_upload_task(
             task_arguments,