Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Commit b64a524

Browse files
Merge branch 'rvinnakota/indirect-misses' into staging
2 parents 8e61482 + 71e4890 commit b64a524

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

codecov/settings_base.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -412,15 +412,13 @@
412412
HttpxIntegration(),
413413
],
414414
environment=SENTRY_ENV,
415-
set_default_pii=True,
416415
traces_sample_rate=SENTRY_SAMPLE_RATE,
417416
profiles_sample_rate=float(
418417
os.environ.get("SERVICES__SENTRY__PROFILE_SAMPLE_RATE", 0.01)
419418
),
420419
)
421420
if os.getenv("CLUSTER_ENV"):
422421
sentry_sdk.set_tag("cluster", os.getenv("CLUSTER_ENV"))
423-
sentry_sdk.set_user({"ip_address": "{{auto}}"})
424422
elif IS_DEV:
425423
sentry_sdk.init(
426424
spotlight=IS_DEV,

compare/commands/compare/interactors/tests/test_fetch_impacted_files.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,7 @@ def test_impacted_files_filtered_by_misses_count_ascending(self, read_file):
511511
}
512512
comparison = None
513513
impacted_files = self.execute(None, self.comparison_report, comparison, filters)
514-
assert [file.head_name for file in impacted_files] == ["fileA", "fileB"]
514+
assert [file.head_name for file in impacted_files] == ["fileB", "fileA"]
515515

516516
@patch("shared.api_archive.archive.ArchiveService.read_file")
517517
def test_impacted_files_filtered_by_misses_count_descending(self, read_file):
@@ -524,7 +524,7 @@ def test_impacted_files_filtered_by_misses_count_descending(self, read_file):
524524
}
525525
comparison = None
526526
impacted_files = self.execute(None, self.comparison_report, comparison, filters)
527-
assert [file.head_name for file in impacted_files] == ["fileB", "fileA"]
527+
assert [file.head_name for file in impacted_files] == ["fileA", "fileB"]
528528

529529
@patch("shared.api_archive.archive.ArchiveService.read_file")
530530
def test_impacted_files_without_filters(self, read_file):

graphql_api/tests/test_impacted_file.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,7 @@ def test_fetch_impacted_files(self, read_file):
404404
"commit": self.commit.commitid,
405405
}
406406
data = self.gql_request(query_impacted_files, variables=variables)
407+
print(data)
407408
assert data == {
408409
"owner": {
409410
"repository": {
@@ -449,7 +450,7 @@ def test_fetch_impacted_files(self, read_file):
449450
"percentCovered": 85.71428571428571
450451
},
451452
"changeCoverage": 44.047619047619044,
452-
"missesCount": 2,
453+
"missesCount": 1,
453454
},
454455
]
455456
},

services/comparison.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -884,7 +884,6 @@ def has_changes(self) -> bool:
884884
def misses_count(self) -> int:
885885
total_misses = 0
886886
total_misses += self._direct_misses_count
887-
total_misses += self._unintended_misses_count
888887
return total_misses
889888

890889
@cached_property

0 commit comments

Comments
 (0)