Avoid N+1 queries fetching Upload.errors

Previously, this was going through an unnecessarily complex Java-esque design pattern, just to execute a query that can be much better served by using a `prefetch_related` Django combinator.

Author: Swatinem

codecov/commands/executor.py

@@ -7,7 +7,6 @@
 from core.commands.flag import FlagCommands
 from core.commands.pull import PullCommands
 from core.commands.repository import RepositoryCommands
-from core.commands.upload import UploadCommands
 from utils.services import get_long_service_name
 
 mapping = {
@@ -17,7 +16,6 @@
     "branch": BranchCommands,
     "compare": CompareCommands,
     "pull": PullCommands,
-    "upload": UploadCommands,
     "flag": FlagCommands,
     "component": ComponentCommands,
 }

core/commands/upload/__init__.py

@@ -5,7 +5,7 @@
 
 from core.models import Commit, Pull, Repository
 from graphql_api.types.enums import CommitStatus
-from reports.models import CommitReport, ReportSession
+from reports.models import CommitReport
 
 
 def pull_commits(pull: Pull) -> QuerySet[Commit]:
@@ -23,29 +23,6 @@ def pull_commits(pull: Pull) -> QuerySet[Commit]:
     return Commit.objects.filter(id__in=subquery).defer("_report")
 
 
-def commit_uploads(commit: Commit) -> QuerySet[ReportSession]:
-    if not commit.commitreport:
-        return ReportSession.objects.none()
-
-    sessions = commit.commitreport.sessions.prefetch_related("flags")
-
-    # # sessions w/ flags and type 'uploaded'
-    # uploaded = sessions.filter(upload_type="uploaded")
-
-    # # carry forward flags that do not have an equivalent uploaded flag
-    # carried_forward = sessions.filter(upload_type="carriedforward").exclude(
-    #     uploadflagmembership__flag_id__in=uploaded.values_list( <------------ FIXME: looks like `flag_id__in` is causing a seq scan in prod
-    #         "uploadflagmembership__flag_id", flat=True
-    #     )
-    # )
-
-    # return (uploaded.prefetch_related("flags")).union(
-    #     carried_forward.prefetch_related("flags")
-    # )
-
-    return sessions
-
-
 def commit_status(
     commit: Commit, report_type: CommitReport.ReportType
 ) -> Optional[CommitStatus]: