Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Commit c790a32

Browse files
committed
fix: pass repoid to get_appropriate_storage_service
if we don't pass the repoid, then it won't check the feature flag, and it will be stuck on the old implementation so it's possible that somewhere else the file is being written using the new implementation, so this will fail to decompress it properly this is just temporary until we hardcode the new impl to be the default
1 parent 0fbad61 commit c790a32

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

graphql_api/dataloader/bundle_analysis.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def load_bundle_analysis_comparison(
3030
return MissingBaseReport()
3131

3232
loader = BundleAnalysisReportLoader(
33-
storage_service=get_appropriate_storage_service(),
33+
storage_service=get_appropriate_storage_service(head_commit.repository.repoid),
3434
repo_key=ArchiveService.get_archive_hash(head_commit.repository),
3535
)
3636

@@ -57,7 +57,7 @@ def load_bundle_analysis_report(
5757
return MissingHeadReport()
5858

5959
loader = BundleAnalysisReportLoader(
60-
storage_service=get_appropriate_storage_service(),
60+
storage_service=get_appropriate_storage_service(commit.repository.repoid),
6161
repo_key=ArchiveService.get_archive_hash(commit.repository),
6262
)
6363
report = loader.load(report.external_id)

services/bundle_analysis.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
def load_report(
3939
commit: Commit, report_code: Optional[str] = None
4040
) -> Optional[SharedBundleAnalysisReport]:
41-
storage = get_appropriate_storage_service()
41+
storage = get_appropriate_storage_service(commit.repository.repoid)
4242

4343
commit_report = commit.reports.filter(
4444
report_type=CommitReport.ReportType.BUNDLE_ANALYSIS,

utils/test_results.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def get_results(
5555

5656
if result is None:
5757
# try storage
58-
storage_service = get_appropriate_storage_service()
58+
storage_service = get_appropriate_storage_service(repoid)
5959
key = storage_key(repoid, branch, interval_start, interval_end)
6060
try:
6161
result = storage_service.read_file(

0 commit comments

Comments
 (0)