Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Commit d65e23b

Browse files
fix test
1 parent a33307c commit d65e23b

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

graphql_api/tests/test_repository.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -513,11 +513,6 @@ def test_repository_is_first_pull_request(self) -> None:
513513

514514
assert data["me"]["owner"]["repository"]["isFirstPullRequest"] == True
515515

516-
assert (
517-
repo.pull_requests.values("id")[:2].query
518-
== 'SELECT "pull_requests"."id" FROM "pull_requests" WHERE "pull_requests"."repoid" = 1 ORDER BY "pull_requests"."pullid" DESC LIMIT 2'
519-
)
520-
521516
def test_repository_is_first_pull_request_compared_to_not_none(self) -> None:
522517
repo = RepositoryFactory(
523518
author=self.owner,

graphql_api/types/repository/repository.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,9 +266,18 @@ def resolve_is_first_pull_request(
266266
repository: Repository, info: GraphQLResolveInfo
267267
) -> bool:
268268
try:
269-
# SELECT "pull_requests"."id" FROM "pull_requests" WHERE "pull_requests"."repoid" = 1 ORDER BY "pull_requests"."pullid" DESC LIMIT 2
270-
pull_requests = repository.pull_requests.values("id")[:2]
271-
return len(pull_requests) == 1
269+
# Get at most 2 PRs to determine if there's only one
270+
# SELECT "pull_requests"."id", "pull_requests"."compared_to" FROM "pull_requests" WHERE "pull_requests"."repoid" = 1 ORDER BY "pull_requests"."pullid" DESC LIMIT 2
271+
pull_requests = repository.pull_requests.values("id", "compared_to")[:2]
272+
273+
# Not first PR if there are multiple or 0 PRs
274+
if len(pull_requests) != 1:
275+
return False
276+
277+
# For single PR, check if it's a valid first PR by verifying no compared_to
278+
first_pr = pull_requests[0]
279+
return first_pr["compared_to"] is None
280+
272281
except Exception as e:
273282
log.error(
274283
"Error checking is_first_pull_request",

0 commit comments

Comments
 (0)