dev: Add Ruff C4 rules (#1072)

Author: ajay-sentry

api/internal/commit/serializers.py

@@ -41,7 +41,7 @@ def get_report(self, commit: Commit):
         for filename in report.files:
             file_report = report.get(filename)
             file_totals = CommitTotalsSerializer(
-                {key: val for key, val in zip(TOTALS_MAP, file_report.totals)}
+                dict(zip(TOTALS_MAP, file_report.totals))
             )
             files.append(
                 {

api/internal/tests/views/test_account_viewset.py

@@ -960,7 +960,7 @@ def test_update_team_plan_must_fail_if_too_many_activated_users_during_trial(sel
         self.current_owner.plan = PlanName.BASIC_PLAN_NAME.value
         self.current_owner.plan_user_count = 1
         self.current_owner.trial_status = TrialStatus.ONGOING.value
-        self.current_owner.plan_activated_users = [i for i in range(11)]
+        self.current_owner.plan_activated_users = list(range(11))
         self.current_owner.save()
 
         desired_plans = [

codecov_auth/tests/test_admin.py

@@ -480,8 +480,8 @@ def test_stale_user_cleanup():
 
     # remove stale users with default > 90 days
     removed_users, affected_orgs = find_and_remove_stale_users(orgs)
-    assert removed_users == set([users[0].ownerid, users[2].ownerid, users[4].ownerid])
-    assert affected_orgs == set([orgs[0].ownerid, orgs[1].ownerid])
+    assert removed_users == {users[0].ownerid, users[2].ownerid, users[4].ownerid}
+    assert affected_orgs == {orgs[0].ownerid, orgs[1].ownerid}
 
     orgs = list(
         Owner.objects.filter(ownerid__in=[org.ownerid for org in orgs])
@@ -493,8 +493,8 @@ def test_stale_user_cleanup():
 
     # remove even more stale users
     removed_users, affected_orgs = find_and_remove_stale_users(orgs, timedelta(days=30))
-    assert removed_users == set([users[1].ownerid, users[3].ownerid])
-    assert affected_orgs == set([orgs[0].ownerid, orgs[1].ownerid])
+    assert removed_users == {users[1].ownerid, users[3].ownerid}
+    assert affected_orgs == {orgs[0].ownerid, orgs[1].ownerid}
 
     orgs = list(
         Owner.objects.filter(ownerid__in=[org.ownerid for org in orgs])

codecov_auth/views/base.py

@@ -302,14 +302,14 @@ def _check_enterprise_organizations_membership(self, user_dict, orgs):
         """Checks if a user belongs to the restricted organizations (or teams if GitHub) allowed in settings."""
         if settings.IS_ENTERPRISE and get_config(self.service, "organizations"):
             orgs_in_settings = set(get_config(self.service, "organizations"))
-            orgs_in_user = set(org["username"] for org in orgs)
+            orgs_in_user = {org["username"] for org in orgs}
             if not (orgs_in_settings & orgs_in_user):
                 raise PermissionDenied(
                     "You must be a member of an organization listed in the Codecov Enterprise setup."
                 )
             if get_config(self.service, "teams") and "teams" in user_dict:
                 teams_in_settings = set(get_config(self.service, "teams"))
-                teams_in_user = set([team["name"] for team in user_dict["teams"]])
+                teams_in_user = {team["name"] for team in user_dict["teams"]}
                 if not (teams_in_settings & teams_in_user):
                     raise PermissionDenied(
                         "You must be a member of an allowed team in your organization."

core/signals.py

@@ -20,7 +20,7 @@ def update_repository(
     changes: Dict[str, Any] = instance.tracker.changed()
     tracked_fields: List[str] = ["name", "upload_token", "activated", "active"]
 
-    if created or any([field in changes for field in tracked_fields]):
+    if created or any(field in changes for field in tracked_fields):
         data = {
             "type": "repo",
             "sync": "one",

graphql_api/dataloader/comparison.py

@@ -42,7 +42,7 @@ def batch_queryset(self, keys):
 
     async def batch_load_fn(self, keys):
         # flat list of all commits involved in all comparisons
-        commitids = set(commitid for key in keys for commitid in key)
+        commitids = {commitid for key in keys for commitid in key}
 
         commit_loader = CommitLoader.loader(self.info, self.repository_id)
         commits = await commit_loader.load_many(commitids)

graphql_api/tests/test_owner_measurements.py

@@ -167,7 +167,7 @@ def test_repository_filtering_by_public_private(
         ]["measurements"]
         params = owner_coverage_measurements_with_fallback.call_args.args
         # Check that the call is using both private and public repos
-        assert set(params[1]) == set([self.repo1.pk, self.repo2.pk])
+        assert set(params[1]) == {self.repo1.pk, self.repo2.pk}
 
         query = f"""
             query Measurements {{
@@ -183,4 +183,4 @@ def test_repository_filtering_by_public_private(
         self.gql_request(query, owner=self.owner)["owner"]["measurements"]
         params = owner_coverage_measurements_with_fallback.call_args.args
         # Check that the call is using both private and public repos
-        assert set(params[1]) == set([self.repo1.pk, self.repo2.pk])
+        assert set(params[1]) == {self.repo1.pk, self.repo2.pk}

graphql_api/types/bundle_analysis/base.py

@@ -307,9 +307,7 @@ def resolve_bundle_report_measurements(
 
     # All measureable names we need to fetch to compute the requested asset types
     if not asset_types:
-        measurables_to_fetch = [
-            item for item in list(BundleAnalysisMeasurementsAssetType)
-        ]
+        measurables_to_fetch = list(BundleAnalysisMeasurementsAssetType)
     elif ASSET_TYPE_UNKNOWN in asset_types:
         measurables_to_fetch = [
             BundleAnalysisMeasurementsAssetType.REPORT_SIZE,
@@ -332,9 +330,7 @@ def resolve_bundle_report_measurements(
 
     # All measureable name we need to return
     if not asset_types:
-        measurables_to_display = [
-            item for item in list(BundleAnalysisMeasurementsAssetType)
-        ]
+        measurables_to_display = list(BundleAnalysisMeasurementsAssetType)
     else:
         measurables_to_display = [
             BundleAnalysisMeasurementsAssetType[item]

graphql_api/types/plan_representation/plan_representation.py

@@ -36,14 +36,12 @@ def resolve_base_unit_price(plan_data: PlanData, info) -> int:
 def resolve_benefits(plan_data: PlanData, info) -> List[str]:
     plan_service: PlanService = info.context["plan_service"]
     if plan_service.is_org_trialing:
-        benefits_with_pretrial_users = list(
-            map(
-                lambda benefit: benefit.replace(
-                    "Up to 1 user", f"Up to {plan_service.pretrial_users_count} users"
-                ),
-                plan_data["benefits"],
+        benefits_with_pretrial_users = [
+            benefit.replace(
+                "Up to 1 user", f"Up to {plan_service.pretrial_users_count} users"
             )
-        )
+            for benefit in plan_data["benefits"]
+        ]
         return benefits_with_pretrial_users
     return plan_data["benefits"]
 

ruff.toml

@@ -39,6 +39,7 @@ target-version = "py312"
 # https://docs.astral.sh/ruff/rules/
 select = [
     "ASYNC", # flake8-async - async checks
+    "C4", # flake8-comprehensions - list/set/dict/generator comprehensions
     "E", # pycodestyle - error rules
     "F", # pyflakes - general Python errors, undefined names
     "I", # isort - import sorting
@@ -47,7 +48,7 @@ select = [
     "PLE", # pylint - error rules
     "W", # pycodestyle - warning rules
 ]
-ignore = ["F405", "F403", "E501", "E712"]
+ignore = ["F405", "F403", "E501", "E712", "C408"]
 
 # Allow fix for all enabled rules (when `--fix`) is provided.
 # The preferred method (for now) w.r.t. fixable rules is to manually update the makefile