Remove Impact Analysis from API

I've stubbed out Impact Analysis fields from the API, as it would take a lot of work to remove them
from Gazebo first. So, just returning a bunch of dummy values for now.

Author: michelletran-sentry

api/internal/owner/serializers.py

@@ -136,7 +136,7 @@ def validate_value(self, value):
                     extra=dict(owner_id=current_owner.pk, plan=value),
                 )
             raise serializers.ValidationError(
-                f"Invalid value for plan: {value}; " f"must be one of {plan_values}"
+                f"Invalid value for plan: {value}; must be one of {plan_values}"
             )
         return value
 

codecov/settings_base.py

@@ -40,7 +40,6 @@
     "core",
     "graphql_api",
     "labelanalysis",
-    "profiling",
     "reports",
     "staticanalysis",
     "timeseries",

codecov/urls.py

@@ -20,7 +20,6 @@
     path("webhooks/", include("webhook_handlers.urls")),
     path("graphql/", include("graphql_api.urls")),
     path("", include("codecov_auth.urls")),
-    path("profiling/", include("profiling.urls")),
     path(f"{settings.DJANGO_ADMIN_URL}/", admin.site.urls),
     path("staticanalysis/", include("staticanalysis.urls")),
     path("labels/", include("labelanalysis.urls")),

codecov_auth/commands/owner/interactors/set_yaml_on_owner.py

@@ -42,7 +42,9 @@ def convert_yaml_to_dict(self, yaml_input: str) -> Optional[dict]:
         except yaml.scanner.ScannerError as e:
             line = e.problem_mark.line
             column = e.problem_mark.column
-            message = f"Syntax error at line {line+1}, column {column+1}: {e.problem}"
+            message = (
+                f"Syntax error at line {line + 1}, column {column + 1}: {e.problem}"
+            )
             raise ValidationError(message)
         if not yaml_dict:
             return None

codecov_auth/commands/owner/interactors/tests/test_set_yaml_on_owner.py

@@ -96,7 +96,7 @@ async def test_user_is_part_of_org_and_yaml_is_good(self):
             "codecov": {
                 "require_ci_to_pass": True,
             },
-            "to_string": "\n" "codecov:\n" "  require_ci_to_pass: yes\n",
+            "to_string": "\ncodecov:\n  require_ci_to_pass: yes\n",
         }
 
     async def test_user_is_part_of_org_and_yaml_has_quotes(self):
@@ -109,7 +109,7 @@ async def test_user_is_part_of_org_and_yaml_has_quotes(self):
             "codecov": {
                 "bot": "codecov",
             },
-            "to_string": "\n" "codecov:\n" "  bot: 'codecov'\n",
+            "to_string": "\ncodecov:\n  bot: 'codecov'\n",
         }
 
     async def test_user_is_part_of_org_and_yaml_is_empty(self):

core/commands/repository/interactors/tests/test_get_repository_token.py

@@ -26,7 +26,7 @@ def setUp(self):
         self.user = OwnerFactory(organizations=[self.org.ownerid])
         RepositoryTokenFactory(repository=self.active_repo, key="random")
 
-    def execute(self, owner, repo, token_type="profiling"):
+    def execute(self, owner, repo, token_type="upload"):
         return GetRepositoryTokenInteractor(owner, "github").execute(
             repository=repo, token_type=token_type
         )
@@ -44,11 +44,6 @@ async def test_when_repo_has_no_token(self):
         assert token is not None
         assert len(token) == 40
 
-    async def test_get_profiling_token(self):
-        token = await self.execute(owner=self.user, repo=self.active_repo)
-        assert token is not None
-        assert token == "random"
-
     async def test_get_static_analysis_token(self):
         token = await self.execute(
             owner=self.user, repo=self.active_repo, token_type="static_analysis"

core/commands/repository/interactors/tests/test_regenerate_repository_token.py

@@ -34,7 +34,7 @@ def execute(self, owner, repo):
         return RegenerateRepositoryTokenInteractor(owner, "github").execute(
             repo_name=repo.name,
             owner_username=self.org.username,
-            token_type="profiling",
+            token_type="upload",
         )
 
     async def test_when_validation_error_repo_not_active(self):
@@ -44,14 +44,3 @@ async def test_when_validation_error_repo_not_active(self):
     async def test_when_validation_error_repo_not_viewable(self):
         with pytest.raises(ValidationError):
             await self.execute(owner=self.random_user, repo=self.active_repo)
-
-    async def test_regenerate_profiling_token_repo_has_no_token(self):
-        token = await self.execute(owner=self.user, repo=self.repo_with_no_token)
-        assert token is not None
-        assert len(token) == 40
-
-    async def test_regenerate_profiling_token(self):
-        token = await self.execute(owner=self.user, repo=self.active_repo)
-        assert token is not None
-        assert token != "random"
-        assert len(token) == 40

graphql_api/tests/mutation/test_regenerate_repository_token.py

@@ -61,26 +61,6 @@ def test_when_validation_error_repo_not_viewable(self):
             == "ValidationError"
         )
 
-    def test_when_authenticated_regenerate_profiling_token(self):
-        user = OwnerFactory(
-            organizations=[self.org.ownerid], permission=[self.repo.repoid]
-        )
-        RepositoryTokenFactory(repository=self.repo, key="random")
-        data = self.gql_request(
-            query,
-            owner=user,
-            variables={
-                "input": {
-                    "owner": "codecov",
-                    "repoName": "gazebo",
-                    "tokenType": "PROFILING",
-                }
-            },
-        )
-        newToken = data["regenerateRepositoryToken"]["token"]
-        assert newToken != "random"
-        assert len(newToken) == 40
-
     def test_when_authenticated_regenerate_staticanalysis_token(self):
         user = OwnerFactory(
             organizations=[self.org.ownerid], permission=[self.repo.repoid]

graphql_api/tests/test_branch.py

@@ -11,7 +11,6 @@
 from shared.reports.types import ReportTotals
 
 from services.components import Component
-from services.profiling import CriticalFile
 
 from .helper import GraphQLTestHelper
 
@@ -338,11 +337,8 @@ def test_fetch_path_contents_with_no_report(self, report_mock):
             }
         }
 
-    @patch(
-        "services.profiling.ProfilingSummary.critical_files", new_callable=PropertyMock
-    )
     @patch("shared.reports.api_report_service.build_report_from_commit")
-    def test_fetch_path_contents_with_files(self, report_mock, critical_files):
+    def test_fetch_path_contents_with_files(self, report_mock):
         variables = {
             "org": self.org.username,
             "repo": self.repo.name,
@@ -356,7 +352,6 @@ def test_fetch_path_contents_with_files(self, report_mock, critical_files):
             },
         }
         report_mock.return_value = MockReport()
-        critical_files.return_value = [CriticalFile("fileA.py")]
 
         data = self.gql_request(query_files, variables=variables)
         assert data == {
@@ -397,7 +392,7 @@ def test_fetch_path_contents_with_files(self, report_mock, critical_files):
                                         "partials": 0,
                                         "lines": 10,
                                         "percentCovered": 80.0,
-                                        "isCriticalFile": True,
+                                        "isCriticalFile": False,
                                     },
                                 ],
                             }
@@ -407,12 +402,10 @@ def test_fetch_path_contents_with_files(self, report_mock, critical_files):
             }
         }
 
-    @patch(
-        "services.profiling.ProfilingSummary.critical_files", new_callable=PropertyMock
-    )
     @patch("shared.reports.api_report_service.build_report_from_commit")
     def test_fetch_path_contents_with_files_and_path_prefix(
-        self, report_mock, critical_files
+        self,
+        report_mock,
     ):
         variables = {
             "org": self.org.username,
@@ -427,7 +420,6 @@ def test_fetch_path_contents_with_files_and_path_prefix(
             },
         }
         report_mock.return_value = MockReport()
-        critical_files.return_value = [CriticalFile("folder/fileB.py")]
 
         data = self.gql_request(query_files, variables=variables)
 
@@ -448,7 +440,7 @@ def test_fetch_path_contents_with_files_and_path_prefix(
                                         "partials": 0,
                                         "lines": 10,
                                         "percentCovered": 80.0,
-                                        "isCriticalFile": True,
+                                        "isCriticalFile": False,
                                     },
                                     {
                                         "__typename": "PathContentDir",
@@ -468,12 +460,10 @@ def test_fetch_path_contents_with_files_and_path_prefix(
             }
         }
 
-    @patch(
-        "services.profiling.ProfilingSummary.critical_files", new_callable=PropertyMock
-    )
     @patch("shared.reports.api_report_service.build_report_from_commit")
     def test_fetch_path_contents_with_files_and_search_value_case_insensitive(
-        self, report_mock, critical_files
+        self,
+        report_mock,
     ):
         variables = {
             "org": self.org.username,
@@ -485,7 +475,6 @@ def test_fetch_path_contents_with_files_and_search_value_case_insensitive(
             },
         }
         report_mock.return_value = MockReport()
-        critical_files.return_value = [CriticalFile("folder/fileB.py")]
 
         data = self.gql_request(query_files, variables=variables)
 
@@ -517,7 +506,7 @@ def test_fetch_path_contents_with_files_and_search_value_case_insensitive(
                                         "partials": 0,
                                         "lines": 10,
                                         "percentCovered": 80.0,
-                                        "isCriticalFile": True,
+                                        "isCriticalFile": False,
                                     },
                                 ],
                             }
@@ -1140,13 +1129,9 @@ def test_fetch_path_contents_component_flags_filters(
             }
         }
 
-    @patch(
-        "services.profiling.ProfilingSummary.critical_files", new_callable=PropertyMock
-    )
     @patch("shared.reports.api_report_service.build_report_from_commit")
-    def test_fetch_path_contents_deprecated(self, report_mock, critical_files_mock):
+    def test_fetch_path_contents_deprecated(self, report_mock):
         report_mock.return_value = MockReport()
-        critical_files_mock.return_value = []
 
         variables = {
             "org": self.org.username,
@@ -1205,15 +1190,12 @@ def test_fetch_path_contents_deprecated(self, report_mock, critical_files_mock):
             }
         }
 
-    @patch(
-        "services.profiling.ProfilingSummary.critical_files", new_callable=PropertyMock
-    )
     @patch("shared.reports.api_report_service.build_report_from_commit")
     def test_fetch_path_contents_deprecated_paginated(
-        self, report_mock, critical_files_mock
+        self,
+        report_mock,
     ):
         report_mock.return_value = MockReport()
-        critical_files_mock.return_value = []
 
         variables = {
             "org": self.org.username,