fix: replace -inf as well

joseph-sentry · joseph-sentry · commit e7c38fd30fe0 · 2024-11-18T14:20:47.000-05:00
diff --git a/graphql_api/types/flake_aggregates/flake_aggregates.py b/graphql_api/types/flake_aggregates/flake_aggregates.py
@@ -44,7 +44,7 @@ def flake_aggregates_with_percentage(
     merged_results = merged_results.with_columns(
         pl.all()
         .pct_change()
-        .replace([float("inf"), None], None)
+        .replace([float("inf"), float("-inf")], None)
         .fill_nan(0)
         .name.suffix("_percent_change")
     )
diff --git a/graphql_api/types/test_results_aggregates/test_results_aggregates.py b/graphql_api/types/test_results_aggregates/test_results_aggregates.py
@@ -73,7 +73,7 @@ def test_results_aggregates_with_percentage(
     merged_results = merged_results.with_columns(
         pl.all()
         .pct_change()
-        .replace([float("inf"), None], None)
+        .replace([float("inf"), float("-inf")], None)
         .fill_nan(0)
         .name.suffix("_percent_change")
     )

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ def flake_aggregates_with_percentage(`
`44`	`44`	`merged_results = merged_results.with_columns(`
`45`	`45`	`pl.all()`
`46`	`46`	`.pct_change()`
`47`		`- .replace([float("inf"), None], None)`
	`47`	`+ .replace([float("inf"), float("-inf")], None)`
`48`	`48`	`.fill_nan(0)`
`49`	`49`	`.name.suffix("_percent_change")`
`50`	`50`	`)`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ def test_results_aggregates_with_percentage(`
`73`	`73`	`merged_results = merged_results.with_columns(`
`74`	`74`	`pl.all()`
`75`	`75`	`.pct_change()`
`76`		`- .replace([float("inf"), None], None)`
	`76`	`+ .replace([float("inf"), float("-inf")], None)`
`77`	`77`	`.fill_nan(0)`
`78`	`78`	`.name.suffix("_percent_change")`
`79`	`79`	`)`