Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Commit e8bbefb

Browse files
Get rid of critical file
1 parent 9f77915 commit e8bbefb

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

graphql_api/tests/test_impacted_file.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
isNewFile
4747
isRenamedFile
4848
isDeletedFile
49-
isCriticalFile
5049
baseCoverage {
5150
percentCovered
5251
}
@@ -422,7 +421,6 @@ def test_fetch_impacted_files(self, read_file):
422421
"isNewFile": False,
423422
"isRenamedFile": False,
424423
"isDeletedFile": False,
425-
"isCriticalFile": False,
426424
"baseCoverage": {
427425
"percentCovered": 41.666666666666664
428426
},
@@ -440,7 +438,6 @@ def test_fetch_impacted_files(self, read_file):
440438
"isNewFile": False,
441439
"isRenamedFile": False,
442440
"isDeletedFile": False,
443-
"isCriticalFile": False,
444441
"baseCoverage": {
445442
"percentCovered": 41.666666666666664
446443
},

graphql_api/types/impacted_file/impacted_file.graphql

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ type ImpactedFile {
55
isNewFile: Boolean!
66
isRenamedFile: Boolean!
77
isDeletedFile: Boolean!
8-
isCriticalFile: Boolean! @deprecated(reason: "Impact Analysis is deprecated.")
98
baseCoverage: CoverageTotals
109
headCoverage: CoverageTotals
1110
patchCoverage: CoverageTotals

graphql_api/types/impacted_file/impacted_file.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -133,14 +133,6 @@ def resolve_misses_count(impacted_file: ImpactedFile, info) -> int:
133133
return impacted_file.misses_count
134134

135135

136-
@sentry_sdk.trace
137-
@impacted_file_bindable.field("isCriticalFile")
138-
@sync_to_async
139-
def resolve_is_critical_file(impacted_file: ImpactedFile, info) -> bool:
140-
"""DEPRECATED. Returning False for all responses."""
141-
return False
142-
143-
144136
impacted_files_result_bindable = UnionType("ImpactedFilesResult")
145137

146138

0 commit comments

Comments
 (0)