Remove BackFillCommitData task/command

I believe this was a data migration that was completed a while back, so the code should now be cleaned up.

Author: Swatinem

core/management/commands/backfill_commits.py

@@ -1,15 +1,10 @@
 import unittest.mock as mock
 from io import StringIO
 
-import fakeredis
 import pytest
 from django.core.management import call_command
 from shared.config import ConfigHelper
-from shared.django_apps.core.tests.factories import (
-    CommitFactory,
-    OwnerFactory,
-    RepositoryFactory,
-)
+from shared.django_apps.core.tests.factories import OwnerFactory, RepositoryFactory
 
 
 @pytest.mark.django_db
@@ -82,90 +77,3 @@ def test_update_gitlab_webhook_command(mocker):
             secret=repo3.webhook_secret,
         ),
     ]
-
-
-@pytest.mark.django_db
-def test_backfill_commits_command(mocker):
-    storage_redis = fakeredis.FakeStrictRedis()
-    celery_redis = fakeredis.FakeStrictRedis()
-    mocker.patch(
-        "core.management.commands.backfill_commits.get_storage_redis",
-        return_value=storage_redis,
-    )
-    mocker.patch(
-        "core.management.commands.backfill_commits.get_celery_redis",
-        return_value=celery_redis,
-    )
-
-    backfill_commits = mocker.patch("services.task.TaskService.backfill_commit_data")
-
-    get_config = mocker.patch("shared.config._get_config_instance")
-    config_helper = ConfigHelper()
-    config_helper.set_params(
-        {
-            "setup": {
-                "webhook_url": "http://example.com",
-            },
-        }
-    )
-    get_config.return_value = config_helper
-
-    commit1 = CommitFactory()
-    commit2 = CommitFactory()
-    commit3 = CommitFactory()
-
-    # undrained queue
-
-    celery_redis.lpush("archive", "placeholder")  # mimic > 0 items in the queue
-    call_command(
-        "backfill_commits",
-        stdout=StringIO(),
-        stderr=StringIO(),
-        batch_size=2,
-    )
-
-    # noop - waits for queue to drain
-    assert backfill_commits.mock_calls == []
-    celery_redis.delete("archive")
-
-    # 1st batch
-
-    call_command(
-        "backfill_commits",
-        stdout=StringIO(),
-        stderr=StringIO(),
-        batch_size=2,
-    )
-
-    assert backfill_commits.mock_calls == [
-        mock.call(commit_id=commit3.id),
-        mock.call(commit_id=commit2.id),
-    ]
-
-    backfill_commits.reset_mock()
-
-    # 2nd batch
-
-    call_command(
-        "backfill_commits",
-        stdout=StringIO(),
-        stderr=StringIO(),
-        batch_size=2,
-    )
-
-    assert backfill_commits.mock_calls == [
-        mock.call(commit_id=commit1.id),
-    ]
-
-    backfill_commits.reset_mock()
-
-    # empty batch
-
-    call_command(
-        "backfill_commits",
-        stdout=StringIO(),
-        stderr=StringIO(),
-        batch_size=2,
-    )
-
-    assert backfill_commits.mock_calls == []

core/tests/test_management_commands.py

@@ -380,14 +380,6 @@ def manual_upload_completion_trigger(
             ),
         ).apply_async()
 
-    def backfill_commit_data(self, commit_id: int):
-        self._create_signature(
-            "app.tasks.archive.BackfillCommitDataToStorage",
-            kwargs=dict(
-                commitid=commit_id,
-            ),
-        ).apply_async()
-
     def preprocess_upload(self, repoid, commitid, report_code):
         self._create_signature(
             "app.tasks.upload.PreProcessUpload",

services/task/task.py

@@ -322,32 +322,3 @@ def test_make_http_request_task(mocker):
         headers=dict(created_timestamp="2023-06-13T10:01:01.000123"),
         immutable=False,
     )
-
-
-@freeze_time("2023-06-13T10:01:01.000123")
-def test_backfill_commit_data_task(mocker):
-    signature_mock = mocker.patch("services.task.task.signature")
-    mock_route_task = mocker.patch(
-        "services.task.task.route_task",
-        return_value={
-            "queue": "celery",
-            "extra_config": {"soft_timelimit": 300, "hard_timelimit": 400},
-        },
-    )
-    TaskService().backfill_commit_data(123)
-    mock_route_task.assert_called_with(
-        "app.tasks.archive.BackfillCommitDataToStorage",
-        args=None,
-        kwargs=dict(commitid=123),
-    )
-    signature_mock.assert_called_with(
-        "app.tasks.archive.BackfillCommitDataToStorage",
-        args=None,
-        kwargs=dict(commitid=123),
-        app=celery_app,
-        queue="celery",
-        soft_time_limit=300,
-        time_limit=400,
-        headers=dict(created_timestamp="2023-06-13T10:01:01.000123"),
-        immutable=False,
-    )