This repository was archived by the owner on Jun 13, 2025. It is now read-only.
feat: handle file not found from CLI #1075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
+ Coverage 96.09% 96.14% +0.05%
==========================================
Files 829 832 +3
Lines 19384 19817 +433
==========================================
+ Hits 18627 19053 +426
- Misses 757 764 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Contributor
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
we want to be able to notify the user with a comment when they get a file not found error from the CLI so this is our way of doing that we create a "placeholder" upload which represents this attempt at an upload that was not able to find a file this upload goes through the upload flow with a placeholder storage path (because we don't want the user to upload anything here) and when it gets to the TA processor, that step will create an upload error which will get notified like all other errors
joseph-sentry
force-pushed
the
joseph/file-not-found-error
branch
from
5d690a7 to
2a1a03b
Compare
adrian-codecov
approved these changes
Jan 20, 2025
Swatinem
approved these changes
Jan 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on the migration from: codecov/shared#471 being run
we want to be able to notify the user with a comment when they get a file not found error from the CLI so this is our way of doing that
we create a "placeholder" upload which represents this attempt at an upload that was not able to find a file
this upload goes through the upload flow with a placeholder storage path (because we don't want the user to upload anything here) and when it gets to the TA processor, that step will create an upload error which will get notified like all other errors