Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

fix: Handle disabled shelter #1093

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix: Handle disabled shelter #1093

merged 1 commit into from
Jan 13, 2025

Conversation

@suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Jan 13, 2025 •
edited
Loading

In self-hosted / enterprise, our customers may not always have shelter deployed. Only initialize the shelter PubSub client if shelter is enabled.
This fixes a bug where regenerateOrgUploadToken was failing when the token object was attempted to create but the corresponding signal failed.

I tested against local gazebo pointed to this with enterprise env vars that an org upload token was generated

Closes codecov/engineering-team#3211

@suejung-sentry suejung-sentry marked this pull request as ready for review January 13, 2025 20:20
@codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.02%. Comparing base (dd38e97) to head (afaf9a7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/shelter.py 50.00% 2 Missing ⚠️
codecov/settings_enterprise.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   96.03%   96.02%   -0.02%     
==========================================
  Files         831      831              
  Lines       19557    19563       +6     
==========================================
+ Hits        18782    18785       +3     
- Misses        775      778       +3
Flag Coverage Δ
unit 92.33% <50.00%> (-0.02%) ⬇️
unit-latest-uploader 92.33% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/shelter.py 50.00% 2 Missing ⚠️
codecov/settings_enterprise.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@adrian-codecov
Copy link
Contributor

adrian-codecov commented Jan 13, 2025

As of now, no self-hosted runs Shelter, but they should in the future when we open source it, so this is good for futureproofing anyway 👌

@suejung-sentry suejung-sentry added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 4c41647 Jan 13, 2025
14 of 19 checks passed
@suejung-sentry suejung-sentry deleted the sshin/3211 branch January 13, 2025 21:13
@suejung-sentry suejung-sentry mentioned this pull request Jan 13, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@adrian-codecov adrian-codecov adrian-codecov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API] Only emit shelter pubsub when shelter is enabled

3 participants

@suejung-sentry @adrian-codecov