feat: move timeseries ORM related code to shared #1135
Conversation
|
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
- Coverage 96.07% 96.05% -0.02%
==========================================
Files 837 837
Lines 19856 19902 +46
==========================================
+ Hits 19076 19117 +41
- Misses 780 785 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
I want to move the models to shared because I want to be able to use the Django models in the worker.
joseph-sentry
force-pushed
the
joseph/timeseries
branch
from
feff708 to
cae56cd
Compare
michelletran-sentry
left a comment
michelletran-sentry
left a comment
There was a problem hiding this comment.
LGTM! I would also suggest testing this on staging.
|
This PR includes changes to |
I want to move the models to shared because I want to be able to use the Django models in the worker.
Follow-up to codecov/shared#500