This repository was archived by the owner on Jun 13, 2025. It is now read-only.
create coverage data in monorepo-friendly way #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 492 494 +2
Lines 16876 16882 +6
=======================================
+ Hits 16188 16194 +6
Misses 688 688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matt-codecov
force-pushed
the
matt/monorepo-friendly-coverage
branch
from
c4cee9e to
f01bb4a
Compare
| rm /app/staging.sh && \ | ||
| rm /app/production.yml && \ | ||
| rm /app/development.yml | ||
| RUN rm /app/apps/codecov-api/codecov/settings_dev.py && \ |
Contributor
There was a problem hiding this comment.
Optional: might be worth adding a const or something for this value to explain what it is
adrian-codecov
approved these changes
Feb 27, 2025
JerrySentry
added a commit
that referenced
this pull request
Mar 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for codecov/umbrella#17
currently the docker image is built and coverage data is generated as if
codecov-apiis its own repo and all the files are in the repo root. inumbrellathat is no longer true -codecov-apiexists inapps/codecov-api/and we want that prefix to be applied to every source file we have data forthis PR sets up
codecov-apiin/app/apps/codecov-apiinstead of/appinside the docker containercodecov-api, path fixing strips those extra directories off the path and nothing is different (see this PR's indirect changes for example)umbrella, path fixing will strip/appbutapps/codecov-apiwill remain like we want (see fix source file paths for coverage data from worker/shared/api umbrella#17 for example)Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.