-
Notifications
You must be signed in to change notification settings - Fork 29
add max age to cookie #1179
add max age to cookie #1179
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 494 494
Lines 16886 16887 +1
=======================================
+ Hits 16192 16193 +1
Misses 694 694
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
adrian-codecov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you have to reimpersonate every 3 minutes? Or this is like 3 minutes after inactivity?
|
huge thanks for doing this! 3 minutes might be too aggressive. but if the support team says 3mins is enough for them to do what they need, aggressive is great |
|
Yeah same thought as Matt, I'd perhaps bump it up a bit, maybe 10 mins? We can always tweak it to more regardless if it feels to short |
c2a3189 to
782cd70
Compare
|
@matt-codecov @adrian-codecov discussed with support team, we will start with 15 min exp 👍 |
782cd70 to
8152625
Compare
This change would cause impersonation to expire after 3 minutes.