Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Mar 3, 2025

Rather than messing with ENV in docker, this uses the test-global config.yml to enable timeseries tests, and switches to a lighter-weight timescale docker image.

@Swatinem Swatinem self-assigned this Mar 3, 2025
@Swatinem Swatinem requested a review from a team as a code owner March 3, 2025 12:17
Rather than messing with ENV in docker, this uses the test-global `config.yml` to enable timeseries tests, and switches to a lighter-weight timescale docker image.
@Swatinem Swatinem force-pushed the swatinem/test-timeseries branch from a70ffc0 to bb9cc52 Compare March 3, 2025 13:13
volumes:
- type: tmpfs
target: /var/lib/postgresql/data
target: /home/postgres/pgdata/data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did an error pop up when you changed the image that caused you to modify this or has this been incorrect the whole time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so according to docs, the postgres data is in a different directory from the upstream postgres images, but actually using that for the tmpfs mount errors because of permissions. really weird, but I ended up deleting the volume definition completely.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (9a787d5) to head (2508e7c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1184   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files         494      494           
  Lines       16887    16887           
=======================================
  Hits        16193    16193           
  Misses        694      694           
Flag Coverage Δ
unit 95.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit 0ec7fe2 Mar 3, 2025
28 checks passed
@Swatinem Swatinem deleted the swatinem/test-timeseries branch March 3, 2025 16:08
@JerrySentry JerrySentry restored the swatinem/test-timeseries branch March 12, 2025 13:45
JerrySentry added a commit that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants