Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Mar 4, 2025

We are using the .flags property in a lot of places where we only ever wanted the .keys(). So lets use get_flag_names instead, which does exactly that.

@Swatinem Swatinem self-assigned this Mar 4, 2025
@Swatinem Swatinem requested a review from a team as a code owner March 4, 2025 16:10
@Swatinem Swatinem marked this pull request as draft March 4, 2025 16:17
@Swatinem Swatinem force-pushed the swatinem/flagnames branch from 35593be to 46acbec Compare March 10, 2025 11:54
@Swatinem Swatinem marked this pull request as ready for review March 10, 2025 11:55
@overwatch-beta
Copy link

overwatch-beta bot commented Mar 10, 2025

✅ Sentry found no issues in your recent changes ✅

@Swatinem Swatinem force-pushed the swatinem/flagnames branch 2 times, most recently from a73dee5 to 3970c17 Compare March 10, 2025 12:51
We are using the `.flags` property in a lot of places where we only ever wanted the `.keys()`.
So lets use `get_flag_names` instead, which does exactly that.
@Swatinem Swatinem force-pushed the swatinem/flagnames branch from 3970c17 to 877fe5b Compare March 11, 2025 08:00
@codecov-notifications
Copy link

codecov-notifications bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (f77e387) to head (877fe5b).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1191   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         493      493           
  Lines       16870    16873    +3     
=======================================
+ Hits        16173    16176    +3     
  Misses        697      697           
Flag Coverage Δ
unit 95.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem Swatinem added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit e1f7b24 Mar 11, 2025
28 of 29 checks passed
@Swatinem Swatinem deleted the swatinem/flagnames branch March 11, 2025 08:17
@sentry
Copy link

sentry bot commented Mar 11, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'NoneType' object has no attribute 'get_flag_names' /api/v2/{service}/{owner_username}/repos/{repo_... View Issue
  • ‼️ GraphQLError: 'NoneType' object has no attribute 'get_flag_names' /graphql/{service} View Issue

Did you find this useful? React with a 👍 or 👎

@JerrySentry JerrySentry restored the swatinem/flagnames branch March 12, 2025 13:45
JerrySentry added a commit that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants