From a14504473b116090becc803dd5f353da3b3a6519 Mon Sep 17 00:00:00 2001 From: Jerry Feng Date: Fri, 7 Mar 2025 13:22:37 -0500 Subject: [PATCH 1/3] Overwatch test 1 --- Makefile | 3 --- services/components.py | 8 ++++++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 499d520efe..bea54b57ab 100644 --- a/Makefile +++ b/Makefile @@ -63,14 +63,11 @@ lint.install.local: uv add --dev ruff lint.run: - ruff check ruff format lint.check: echo "Linting..." - ruff check echo "Formatting..." - ruff format --check build.requirements: # if docker pull succeeds, we have already build this version of diff --git a/services/components.py b/services/components.py index 318e22e01b..190dee1237 100644 --- a/services/components.py +++ b/services/components.py @@ -31,6 +31,14 @@ def component_filtered_report( """ Filter a report such that the totals, etc. are only pertaining to the given component. """ + print(report) + print(components) + + # This will fail mypy with "Item "None" of "Optional[Report]" has no attribute "filter"" + # Because we're not checking if report is None before accessing filter() + report: Optional[Report] = report + filtered_report = report.filter(flags=flags, paths=paths) + flags, paths = [], [] for component in components: flags.extend(component.get_matching_flags(report.flags.keys())) From fe0e5f171cc93f84e57ae18eb8cddf0f4db473b9 Mon Sep 17 00:00:00 2001 From: Jerry Feng Date: Wed, 12 Mar 2025 09:37:07 -0400 Subject: [PATCH 2/3] Add upload-overwatch.yml workflow for PR #1204 --- .github/workflows/upload-overwatch.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/upload-overwatch.yml b/.github/workflows/upload-overwatch.yml index 62a3358cd0..fedcf3494b 100644 --- a/.github/workflows/upload-overwatch.yml +++ b/.github/workflows/upload-overwatch.yml @@ -1,10 +1,13 @@ -name: Upload Overwatch +name: Upload Overwatch - TEST on: pull_request: types: - opened - synchronize + push: + branches-ignore: + - main jobs: upload-overwatch: @@ -36,8 +39,9 @@ jobs: chmod +x overwatch-cli - name: Run Overwatch CLI run: | - ./overwatch-cli \ - --auth-token ${{ secrets.SENTRY_AUTH_TOKEN }} \ - --organization-slug codecov \ - python \ - --python-path $(which python3) \ No newline at end of file + ./overwatch-cli \\ + --auth-token \${{ secrets.SENTRY_AUTH_TOKEN }} \\ + --organization-slug codecov \\ + --pullid 1204 \\ + python \\ + --python-path \$(which python3) \ No newline at end of file From a823ef60a5d712b0a7483cea4f605b47fddee1e1 Mon Sep 17 00:00:00 2001 From: Jerry Feng Date: Wed, 12 Mar 2025 09:39:33 -0400 Subject: [PATCH 3/3] Add upload-overwatch.yml workflow for PR #1204 --- .github/workflows/upload-overwatch.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/upload-overwatch.yml b/.github/workflows/upload-overwatch.yml index fedcf3494b..b3c928f4bc 100644 --- a/.github/workflows/upload-overwatch.yml +++ b/.github/workflows/upload-overwatch.yml @@ -1,4 +1,5 @@ -name: Upload Overwatch - TEST +# Created on 2025-03-12 09:39:33 +name: Upload Overwatch - 2025-03-12 09:39:33 on: pull_request: @@ -39,9 +40,9 @@ jobs: chmod +x overwatch-cli - name: Run Overwatch CLI run: | - ./overwatch-cli \\ - --auth-token \${{ secrets.SENTRY_AUTH_TOKEN }} \\ - --organization-slug codecov \\ - --pullid 1204 \\ - python \\ - --python-path \$(which python3) \ No newline at end of file + ./overwatch-cli \ + --auth-token ${{ secrets.SENTRY_AUTH_TOKEN }} \ + --organization-slug codecov \ + --pullid 1204 \ + python \ + --python-path $(which python3)