This repository was archived by the owner on Jun 13, 2025. It is now read-only.
"Fix" errors calling get_flag_names on None
#1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent switch to `get_flag_names` has caused a couple of "new" Sentry errors. Though they are not really "new", but rather just different from previous errors. It seems like the existing code is passing `None` as Report in a bunch of places, and has seemingly always done so. The error now is just a different one. Nonetheless, I paper over that error in some places by defaulting to `[]` instead on an empty Report. The code will still fail on a different line though.
🚨 Sentry detected 8 potential issues in your recent changes 🚨
Lower risk findings
|
joseph-sentry
approved these changes
Mar 12, 2025
JerrySentry
added a commit
that referenced
this pull request
Mar 18, 2025
Contributor
✅ Sentry found no issues in your recent changes ✅ |
JerrySentry
added a commit
that referenced
this pull request
Mar 19, 2025
JerrySentry
added a commit
that referenced
this pull request
Mar 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent switch to
get_flag_nameshas caused a couple of "new" Sentry errors. Though they are not really "new", but rather just different from previous errors.It seems like the existing code is passing
Noneas Report in a bunch of places, and has seemingly always done so. The error now is just a different one.Nonetheless, I paper over that error in some places by defaulting to
[]instead on an empty Report. The code will still fail on a different line though."Fixes" API-BF1, API-BEZ and API-BF2