-
Notifications
You must be signed in to change notification settings - Fork 29
fix: replace NaN values in deduped TA table #1211
Conversation
🚨 Sentry detected 10 potential issues in your recent changes 🚨Lower risk findings
Did you find this useful? React with a 👍 or 👎 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 492 492
Lines 16810 16814 +4
=======================================
+ Hits 16190 16194 +4
Misses 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| * (pl.col("total_pass_count") + pl.col("total_fail_count")) | ||
| ).sum() / (pl.col("total_pass_count") + pl.col("total_fail_count")).sum() | ||
|
|
||
| # dedup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very helpful comment ;)
468a702 to
e604c8d
Compare
e604c8d to
9d146d2
Compare
ajay-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
2 things: