Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@joseph-sentry
Copy link
Contributor

2 things:

  • moving dedup from the test_analytics resolver to get_results
  • changing dedup to fill_nan values with 0

@joseph-sentry joseph-sentry requested a review from a team as a code owner March 13, 2025 17:26
@seer-by-sentry
Copy link
Contributor

seer-by-sentry bot commented Mar 13, 2025

🚨 Sentry detected 10 potential issues in your recent changes 🚨

Lower risk findings

Did you find this useful? React with a 👍 or 👎

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.31%. Comparing base (a9bc72c) to head (9d146d2).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files         492      492           
  Lines       16810    16814    +4     
=======================================
+ Hits        16190    16194    +4     
  Misses        620      620           
Flag Coverage Δ
unit 96.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* (pl.col("total_pass_count") + pl.col("total_fail_count"))
).sum() / (pl.col("total_pass_count") + pl.col("total_fail_count")).sum()

# dedup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very helpful comment ;)

@joseph-sentry joseph-sentry force-pushed the joseph/fix-ta branch 2 times, most recently from 468a702 to e604c8d Compare March 19, 2025 16:32
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-notifications
Copy link

codecov-notifications bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@joseph-sentry joseph-sentry added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit b1440be Mar 19, 2025
23 of 24 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-ta branch March 19, 2025 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants