This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Use cache instance directly from shared
#1266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 490 487 -3
Lines 16915 16891 -24
=======================================
- Hits 16292 16269 -23
+ Misses 623 622 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joseph-sentry
approved these changes
Apr 2, 2025
Swatinem
force-pushed
the
swatinem/shared-cache
branch
from
079dd18 to
3b24252
Compare
As a driveby change, this also removes some duplicated code that is rather consumed from `shared` directly.
Swatinem
force-pushed
the
swatinem/shared-cache
branch
from
3b24252 to
822ab7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a driveby change, this also removes some duplicated code that is rather consumed from
shareddirectly.Depends on codecov/shared#597