This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Correct kwarg for get_github_integration_token
#1268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed a fn which has only directly forwarded calls to the other fn in shared, but renamed one of the kwargs, which I missed. This now renames the kwarg properly.
Contributor
✅ Sentry found no issues in your recent changes ✅ |
giovanni-guidini
approved these changes
Apr 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 487 487
Lines 16891 16891
=======================================
Hits 16269 16269
Misses 622 622
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed a fn which has only directly forwarded calls to the other fn in shared, but renamed one of the kwargs, which I missed.
This now renames the kwarg properly.
Fixes a small regression from #1266
Fixes API-BSR